fix: Fix orientation updating to portrait when phone is flat
#3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
Author
|
Released in v4.6.4! 🥳 |
tomtargosz
pushed a commit
to tomtargosz/react-native-vision-camera
that referenced
this pull request
Feb 21, 2025
…avy#3423) * fix: Fix orientation updating to `portrait` when phone is flat * fix: Make `[weak self]`
zehra-tok
pushed a commit
to tos-analytics/react-native-vision-camera
that referenced
this pull request
Oct 21, 2025
…avy#3423) * fix: Fix orientation updating to `portrait` when phone is flat * fix: Make `[weak self]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously, when the phone is flat,
outputOrientationwould be updated to'portrait'- which is not correct since it can also be landscape before the phone is being laid flat.Instead, we now return
nilif the orientation is flat, since it is not known how the user is holding the phone. In other words, we skip an orientation update for flat now.Changes
Tested on
Related issues