feat(editor): Resolve `$parameter[...]` in UI-only context & add Docker build workflow #18182

avri-schneider · 2025-08-10T09:22:30Z

UI enhancement:

Added support for resolving $parameter[...] expressions in the Node Details View when no execution data is available.
Falls back to reading values directly from activeNode.parameters when execution context is missing.
Improves editing experience by allowing preview of resolved parameters without running the workflow.
Added unit tests to verify $parameter[...] resolution in UI-only mode.

CI/CD improvements:

Introduced GitHub Actions workflow to build and test n8n Docker images on Linux runners, avoiding Windows-specific path/symlink issues.
Added automated container testing before publishing.

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

CLAassistant · 2025-08-10T09:22:36Z

All committers have signed the CLA.

cubic-dev-ai

cubic analysis

3 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.ts

.github/workflows/test-docker-build.yml

Joffcom · 2025-08-10T09:30:28Z

Hey @avri-schneider,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-3643". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

avri-schneider · 2025-08-10T11:37:24Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T11:37:36Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

3 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.ts

.github/workflows/test-docker-build.yml

avri-schneider · 2025-08-10T14:05:40Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T14:05:46Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

4 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.ts

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.test.ts

.github/workflows/test-docker-build.yml

avri-schneider · 2025-08-10T14:22:31Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T14:22:37Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

2 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

.github/workflows/test-docker-build.yml

avri-schneider · 2025-08-10T14:54:45Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T14:54:51Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

No issues found across 4 files. Review in cubic

…factor, and Docker build workflow UI enhancements: - Added support for resolving `$parameter[...]` expressions in the Node Details View when no execution data is available. - Falls back to reading values from `activeNode.parameters` when execution context is missing. - Allows preview of resolved parameters without running the workflow. - Added unit tests to verify `$parameter[...]` resolution in UI-only mode. Type-safety improvements: - Removed all unchecked `as` type assertions in parameter resolution. - `resolveParameterFromUiContext` now returns `NodeParameterValue | null` instead of using generic + cast. - Added optional `uiPreviewGuard` to `ResolveParameterOptions` for safe narrowing. - Used function overloads and runtime type guards for `ResolveParameterOptions` vs `ExpressionLocalResolveContext` to comply with “Prefer Typeguards over Type casting”. CI/CD improvements: - Introduced GitHub Actions workflow to build and test n8n Docker images on Linux runners. - Automated container testing before publishing. - Fixed GHCR image deletion by reading `docker-content-digest` header via `curl -sI` instead of incorrect `.config.digest` parsing. - Removed unsupported `build-record` input from docker/build-push-action to prevent runtime errors. - Made workflow fail on type errors. - Pinned GitHub Actions to commit SHAs. - Fixed PNPM version pinning and prevented `latest` tag overwrite in test-docker-build workflow.

avri-schneider · 2025-08-10T15:04:40Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T15:04:47Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

2 issues found across 4 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

.github/workflows/test-docker-build.yml

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

- Replace passive `|| echo` health check with bounded retry loop (120s max) - Fail job if `/healthz` endpoint never becomes healthy - Add log and container state dump on failure for easier debugging - Simplify cleanup by using `docker rm -f` with `trap` and `|| true` - Remove redundant `docker stop` before `rm`

avri-schneider · 2025-08-10T18:43:57Z

@cubic-dev-ai re-run the review

cubic-dev-ai · 2025-08-10T18:44:04Z

@cubic-dev-ai re-run the review

@avri-schneider I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

cubic analysis

No issues found across 4 files. Review in cubic

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.ts Outdated Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Aug 10, 2025

avri-schneider mentioned this pull request Aug 10, 2025

Webhook Node URL Path Not Updating from /null After Saving (v1.88.0, Local Docker Desktop + Nginx Proxy) #14856

Closed

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

packages/frontend/editor-ui/src/composables/useWorkflowHelpers.ts Outdated Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

avri-schneider force-pushed the feat/editor-resolve-parameter-ui-only branch from 00da42f to bbcd1d3 Compare August 10, 2025 13:08

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

.github/workflows/test-docker-build.yml Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

avri-schneider force-pushed the feat/editor-resolve-parameter-ui-only branch from 333a73d to b211eed Compare August 10, 2025 15:03

avri-schneider force-pushed the feat/editor-resolve-parameter-ui-only branch from b211eed to 6ce41f9 Compare August 10, 2025 15:03

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

.github/workflows/test-docker-build.yml Outdated Show resolved Hide resolved

avri-schneider and others added 2 commits August 10, 2025 18:09

Update .github/workflows/test-docker-build.yml

f8e0c95

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

avri-schneider closed this Aug 11, 2025

feat(editor): Resolve $parameter[...] in UI-only context & add Docker build workflow #18182

feat(editor): Resolve $parameter[...] in UI-only context & add Docker build workflow #18182

Uh oh!

Conversation

avri-schneider commented Aug 10, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

Uh oh!

CLAassistant commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Joffcom commented Aug 10, 2025

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

Uh oh!

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

Uh oh!

Uh oh!

avri-schneider commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot commented Aug 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

feat(editor): Resolve `$parameter[...]` in UI-only context & add Docker build workflow #18182

feat(editor): Resolve `$parameter[...]` in UI-only context & add Docker build workflow #18182

CLAassistant commented Aug 10, 2025 •

edited

Loading