-
Notifications
You must be signed in to change notification settings - Fork 50.8k
feat(core): Use active version instead of current version (no-changelog) #21202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
2fd0466 to
8e956c4
Compare
a2dd502 to
bbc3af0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 15 files
48ac94d to
bbc3af0
Compare
94a8dcf to
232d38e
Compare
|
E2E Tests: n8n tests timed out after 30m Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
…s will have workflow history)
This comment has been minimized.
This comment has been minimized.
packages/cli/src/environments.ee/source-control/source-control-import.service.ee.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
tomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit comment. Feel free to merge without addressing
Summary
This PR decouples the active version from the current version of the workflow:
activeVersionIdto the workflow entityactiveflag, but we will tackle this as tech debt later.activeVersionwith the current version when updating and activating workflowsactiveVersionfor GET endpoints (it'll be the same as the current version until user starts using V2 endpoints)excludePinnedDatafrom activate endpoint (it was unused and using "GET" type was semantically incorrect)activeVersionis set once along with the workflow entity updateActive Version Usage
These are now using the active workflow version:
active-workflow-manager.ts- add]activeVersionnodes and connections instead of current version.active-workflow-manager.ts- clearWebhooks]activeVersionto properly identify and clean up the correct webhooks.active-workflow-manager.ts- activateWorkflow]activeVersioninstead of current version.live-webhooks.ts- executeWebhook]activeVersioninstead of current version.What I tested and how
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-4277/feature-be-decouple-current-workflow-version-from-active-version
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)