perf(editor): Render chat sidebar faster (no-changelog) #22039

autologie · 2025-11-19T12:42:50Z

Summary

This PR improves chat sidebar performance by introducing pagination of the conversation list and optimizing the UI logic for rendering to reduce dependent API responses. Also adds skeleton to provide clear feedback to users while loading.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

bundlemon · 2025-11-19T12:49:12Z

BundleMon

Unchanged files (2)

Status	Path	Size	Limits
✅	WASM Dependencies _{tree-sitter-bash.wasm}	181.26KB	-
✅	WASM Dependencies _{tree-sitter.wasm}	74.47KB	-

No change in files bundle size

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	11.34MB (+47.8KB +0.41%)	-
✅	*/.css	227.69KB (+6.91KB +3.13%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codecov · 2025-11-19T12:52:35Z

Codecov Report

❌ Patch coverage is 10.82803% with 140 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...nd/editor-ui/src/features/ai/chatHub/chat.store.ts	0.00%	68 Missing ⚠️
...tures/ai/chatHub/components/ChatSidebarContent.vue	0.00%	25 Missing ⚠️
...ures/ai/chatHub/components/ChatSessionMenuItem.vue	0.00%	18 Missing ⚠️
...end/editor-ui/src/features/ai/chatHub/ChatView.vue	0.00%	8 Missing ⚠️
...tend/editor-ui/src/features/ai/chatHub/chat.api.ts	0.00%	8 Missing ⚠️
...src/features/ai/chatHub/components/ChatMessage.vue	0.00%	6 Missing ⚠️
...eatures/ai/chatHub/components/SkeletonMenuItem.vue	0.00%	5 Missing ⚠️
...es/cli/src/modules/chat-hub/chat-hub.controller.ts	0.00%	1 Missing ⚠️
...eatures/ai/chatHub/components/AgentEditorModal.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

autologie · 2025-11-19T12:53:22Z

packages/cli/src/modules/chat-hub/chat-hub.controller.ts

 	async getConversations(
 		req: AuthenticatedRequest,
 		_res: Response,
+		@Query query: ChatHubConversationsRequest,


The conversation list endpoint is fast enough without pagination, but it does slow down rendering UI when many items are returned. This is still the case if the user scrolls the list very far, but I think we can keep it for later

Yeah, this seems good enough for now I think 👍

cubic-dev-ai

5 issues found across 15 files

Prompt for AI agents (all 5 issues)


Understand the root cause of the following 5 issues and fix them.


<file name="packages/cli/src/modules/chat-hub/chat-hub.service.ts">

<violation number="1" location="packages/cli/src/modules/chat-hub/chat-hub.service.ts:1514">
Rule violated: **Tests**

Cursor-based pagination (`nextCursor`/`hasMore`) was added to `getConversations` without any tests covering the new limit/cursor invariants, leaving this core listing logic unverified despite the Community PR Guideline requiring tests for new functionality.</violation>
</file>

<file name="packages/cli/src/modules/chat-hub/chat-session.repository.ts">

<violation number="1" location="packages/cli/src/modules/chat-hub/chat-session.repository.ts:61">
Rule violated: **Tests**

Community PR Guidelines §2 require tests for core functionality. The new paginated/cursor-aware `getManyByUserId` implementation adds limit handling and a NotFound error path but the chat-hub test suite contains no coverage for cursor pagination or the new error case. Please add unit or integration tests that verify limiting, cursor-based continuation, and the missing-cursor error.</violation>

<violation number="2" location="packages/cli/src/modules/chat-hub/chat-session.repository.ts:76">
Cursor pagination can return duplicate items: the filter uses `lastMessageAt &lt;= cursor` with `id != cursor`, so records with the same timestamp but smaller IDs (already seen in a prior page) satisfy the cursor clause and get re-sent. Use a lexicographical comparison matching the sort order to advance strictly past the cursor.</violation>
</file>

<file name="packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts:282">
`sessionsLoadingMore` is set to true before the API call but never reset when `fetchSessionsApi` rejects, so a failed request permanently blocks further pagination. Wrap the call in try/finally to clear the flag on both success and error.</violation>

<violation number="2" location="packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts:333">
Calling `.some` on `sessions.value?.data` will throw if `sessions.value` is still undefined; use optional chaining on `data` (or default to an empty array) so the check doesn’t crash when the session list hasn’t loaded yet.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/cli/src/modules/chat-hub/chat-hub.service.ts

packages/cli/src/modules/chat-hub/chat-session.repository.ts

packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts

Cadiac · 2025-11-19T15:06:02Z

packages/cli/src/modules/chat-hub/chat-session.repository.ts

+			.addOrderBy('session.id', 'ASC');
+
+		if (cursor) {
+			const cursorSession = await this.findOne({


instead of just ID as the cursor we could also make the endpoint receive lastMessageAt from the FE, skipping the need for this query 🤔

but I think we don't need to improve this further, seems fast enough & this ensures the session belongs to the user too which is nice

Cadiac

We still might need to revisit these performance improvements to skip loading all the credentials which is slow on internal (with thousands of credentials available). but this seems like an improvement to the initial draw speed anyways 👍

I was thinking it would be nice if we could only load credentials of relevant types. We could also change the model selector to load the providers only one by one when it is opened / providers are expanded, instead of loading all models from all providers like we do now 🤔

Cadiac · 2025-11-19T15:15:41Z

Actually it looks like one of the tests is actually failing on postgres, you might want to take a look on that 🤔

autologie · 2025-11-20T09:10:34Z

We still might need to revisit these performance improvements to skip loading all the credentials which is slow on internal (with thousands of credentials available). but this seems like an improvement to the initial draw speed anyways 👍

I was thinking it would be nice if we could only load credentials of relevant types. We could also change the model selector to load the providers only one by one when it is opened / providers are expanded, instead of loading all models from all providers like we do now 🤔

yes, the main chat pane is still slow. Fetching only relevant models/credentials sounds a good idea.

currents-bot · 2025-11-20T13:50:49Z

✅

E2E Tests: n8n tests passed after 11m 58.6s

🟢 583 · 🔴 0 · ⚪️ 12 · 🟣 6

View Run Details

Run Details

Project: n8n
Groups: 2
Framework: Playwright
Run Status: Passed
Commit: d87b1d4
Spec files: 95
Overall tests: 595
Duration: 11m 58.6s
Parallelization: 8

Groups

GroupId	Results	Spec Files Progress
ui	🟢 528 · 🔴 0 · ⚪️ 12 · 🟣 6	88 / 88
ui:isolated	🟢 55 · 🔴 0 · ⚪️ 0	7 / 7

This message was posted automatically by currents.dev | Integration Settings

n8n-assistant · 2025-11-25T12:30:19Z

Got released with [email protected]

autologie added 4 commits November 19, 2025 12:34

change error message styling

c293ba3

cleanup

9e9ca96

feat: paginate conversation list

a96733b

refactor

7c091a9

autologie commented Nov 19, 2025

View reviewed changes

autologie requested a review from Cadiac November 19, 2025 12:54

cubic-dev-ai bot reviewed Nov 19, 2025

View reviewed changes

autologie added 2 commits November 19, 2025 14:07

fix: reset sessionsLoadingMore when request fails

6431e1e

fix query and add integration tests

23685a0

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 19, 2025

This comment has been minimized.

Sign in to view

Cadiac reviewed Nov 19, 2025

View reviewed changes

autologie added 2 commits November 19, 2025 16:31

specify null handling explicitly

c08554c

change the approach of null handling

c5293c1

This comment has been minimized.

Sign in to view

fix string literal quotation for postgres

a836a80

autologie added 3 commits November 20, 2025 13:39

Merge branch 'master' into conversation-list-pagination

1052e26

Merge branch 'master' into conversation-list-pagination

7d561a8

cleanup unused import

d87b1d4

autologie requested a review from Cadiac November 20, 2025 13:36

Cadiac approved these changes Nov 20, 2025

View reviewed changes

autologie merged commit 11e111e into master Nov 20, 2025
33 checks passed

autologie deleted the conversation-list-pagination branch November 20, 2025 13:55

konstantintieber pushed a commit that referenced this pull request Nov 21, 2025

perf(editor): Render chat sidebar faster (no-changelog) (#22039)

e0f000e

n8n-assistant bot added the Released label Nov 25, 2025

perf(editor): Render chat sidebar faster (no-changelog) #22039

perf(editor): Render chat sidebar faster (no-changelog) #22039

Uh oh!

Conversation

autologie commented Nov 19, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

Uh oh!

bundlemon bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

codecov bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

autologie Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Cadiac Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Cadiac Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Cadiac left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Cadiac commented Nov 19, 2025

Uh oh!

This comment has been minimized.

autologie commented Nov 20, 2025

Uh oh!

currents-bot bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

n8n-assistant bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bundlemon bot commented Nov 19, 2025 •

edited

Loading

codecov bot commented Nov 19, 2025 •

edited

Loading

autologie Nov 19, 2025 •

edited

Loading

Cadiac left a comment •

edited

Loading

currents-bot bot commented Nov 20, 2025 •

edited

Loading