feat(editor): CSV download support for data tables #22048

nikhilkuria · 2025-11-19T16:07:21Z

Summary

Tested with 50 MB of data in a single data table. The download happens in <3 seconds.
If there is a need to support bigger tables, we can add streaming support later

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

cubic-dev-ai

2 issues found across 7 files

Prompt for AI agents (all 2 issues)


Understand the root cause of the following 2 issues and fix them.


<file name="packages/frontend/editor-ui/src/features/core/dataTable/dataTable.store.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/core/dataTable/dataTable.store.ts:277">
Rule violated: **Tests**

`downloadDataTableCsv` introduces a new CSV export path (API call plus DOM-triggered download) but no unit/UI tests were added to cover it, violating the Community PR Guidelines §2 testing requirement for new functionality.</violation>
</file>

<file name="packages/cli/src/modules/data-table/data-table.controller.ts">

<violation number="1" location="packages/cli/src/modules/data-table/data-table.controller.ts:265">
This endpoint returns full table data but is guarded only by `dataTable:read`, letting callers who can see metadata download entire datasets without the `dataTable:readRow` permission that other row-returning routes require. Align the scope with existing row access to prevent unauthorized data export.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-11-19T18:38:48Z

packages/frontend/editor-ui/src/features/core/dataTable/dataTable.store.ts

 		return result;
 	};

+	const downloadDataTableCsv = async (dataTableId: string, projectId: string) => {


Rule violated: Tests

downloadDataTableCsv introduces a new CSV export path (API call plus DOM-triggered download) but no unit/UI tests were added to cover it, violating the Community PR Guidelines §2 testing requirement for new functionality.

Prompt for AI agents

Address the following comment on packages/frontend/editor-ui/src/features/core/dataTable/dataTable.store.ts at line 277: <comment>`downloadDataTableCsv` introduces a new CSV export path (API call plus DOM-triggered download) but no unit/UI tests were added to cover it, violating the Community PR Guidelines §2 testing requirement for new functionality.</comment> <file context> @@ -273,6 +274,36 @@ export const useDataTableStore = defineStore(DATA_TABLE_STORE, () => { return result; }; + const downloadDataTableCsv = async (dataTableId: string, projectId: string) => { + // Fetch CSV content with authentication + const { csvContent, filename } = await downloadDataTableCsvApi( </file context>

cubic-dev-ai · 2025-11-19T18:38:48Z

packages/cli/src/modules/data-table/data-table.controller.ts

 	}

+	@Get('/:dataTableId/download-csv')
+	@ProjectScope('dataTable:read')


This endpoint returns full table data but is guarded only by dataTable:read, letting callers who can see metadata download entire datasets without the dataTable:readRow permission that other row-returning routes require. Align the scope with existing row access to prevent unauthorized data export.

Prompt for AI agents

Address the following comment on packages/cli/src/modules/data-table/data-table.controller.ts at line 265: <comment>This endpoint returns full table data but is guarded only by `dataTable:read`, letting callers who can see metadata download entire datasets without the `dataTable:readRow` permission that other row-returning routes require. Align the scope with existing row access to prevent unauthorized data export.</comment> <file context> @@ -261,6 +261,36 @@ export class DataTableController { } + @Get('/:dataTableId/download-csv') + @ProjectScope('dataTable:read') + async downloadDataTableCsv( + req: AuthenticatedRequest<{ projectId: string; dataTableId: string }>, </file context>

Suggested change

@ProjectScope('dataTable:read')

@ProjectScope('dataTable:readRow')

…8n-io/n8n into feature-export-csv-data-tables

bundlemon · 2025-11-19T18:53:27Z

BundleMon

Unchanged files (2)

Status	Path	Size	Limits
✅	WASM Dependencies _{tree-sitter-bash.wasm}	181.26KB	-
✅	WASM Dependencies _{tree-sitter.wasm}	74.47KB	-

No change in files bundle size

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	11.34MB (+51.03KB +0.44%)	-
✅	*/.css	227.73KB (+6.96KB +3.15%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codecov · 2025-11-19T18:56:04Z

Codecov Report

❌ Patch coverage is 58.82353% with 49 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...-ui/src/features/core/dataTable/dataTable.store.ts	15.62%	27 Missing ⚠️
...or-ui/src/features/core/dataTable/dataTable.api.ts	6.25%	15 Missing ⚠️
...li/src/modules/data-table/data-table.controller.ts	60.00%	4 Missing ⚠️
...s/cli/src/modules/data-table/data-table.service.ts	93.02%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

RicardoE105 · 2025-11-19T23:49:08Z

packages/cli/src/modules/data-table/data-table.service.ts

+	): Promise<{ csvContent: string; dataTableName: string }> {
+		const dataTable = await this.validateDataTableExists(dataTableId, projectId);
+
+		// Fetch columns (ordered by index)


nick: I guess we do not need all these comments?

Same with the comments below.

Claude was very generous with the comments. Cleaned them out.

RicardoE105 · 2025-11-19T23:51:35Z

packages/frontend/editor-ui/src/features/core/dataTable/components/DataTableActions.vue


 const actions = computed<Array<UserAction<IUser>>>(() => {
 	const availableActions = [
+		{


I'm surprised that we added this here and not next to the search input

RicardoE105 · 2025-11-19T23:54:48Z

packages/cli/src/modules/data-table/data-table.controller.ts


+	@Get('/:dataTableId/download-csv')
+	@ProjectScope('dataTable:read')
+	async downloadDataTableCsv(


Can we add a integration test for this endpoint? that will automatically add coverage to all the backend code (or most of it)

RicardoE105 · 2025-11-20T00:02:47Z

packages/cli/src/modules/data-table/data-table.service.ts

+		const str = String(value);
+
+		// RFC 4180 compliant escaping:
+		// - If value contains comma, quote, or newline, wrap in quotes
+		// - Escape quotes by doubling them
+		if (str.includes(',') || str.includes('"') || str.includes('\n') || str.includes('\r')) {
+			return `"${str.replace(/"/g, '""')}"`;
+		}
+
+		return str;
+	}


Looks like leading/trailing whitespace won't be preserved. Was this intentional? I guess we should keep the original data as it comes.

Good point. Made the change so that if there is leading or trailing whitespace, the string will be in quotes. This helps import to google sheets.

RicardoE105 · 2025-11-20T00:08:49Z

packages/frontend/editor-ui/src/features/core/dataTable/dataTable.store.ts

 		return result;
 	};

+	const downloadDataTableCsv = async (dataTableId: string, projectId: string) => {


We can make this readable like this:

const UTF8_BOM = '\uFEFF'; const createCsvBlob = (csvContent: string): Blob => { // Add BOM for Excel compatibility with special characters return new Blob([UTF8_BOM + csvContent], { type: 'text/csv;charset=utf-8;' }); }; const triggerBrowserDownload = (blob: Blob, filename: string): void => { const url = URL.createObjectURL(blob); const link = document.createElement('a'); link.href = url; link.download = filename; link.style.display = 'none'; document.body.appendChild(link); try { link.click(); } finally { document.body.removeChild(link); URL.revokeObjectURL(url); } }; const downloadDataTableCsv = async (dataTableId: string, projectId: string) => { const { csvContent, filename } = await downloadDataTableCsvApi( rootStore.restApiContext, dataTableId, projectId, ); const csvBlob = createCsvBlob(csvContent); triggerBrowserDownload(csvBlob, filename); };

currents-bot · 2025-11-20T17:15:22Z

✅

E2E Tests: n8n tests passed after 8m 57.9s

🟢 73 · 🔴 0 · ⚪️ 2 · 🟣 1

View Run Details

Run Details

Project: n8n
Groups: 2
Framework: Playwright
Run Status: Passed
Commit: 3b86f72
Spec files: 96
Overall tests: 600
Duration: 8m 57.9s
Parallelization: 1

Groups

GroupId	Results	Spec Files Progress
ui	🟢 73 · 🔴 0 · ⚪️ 2 · 🟣 1	6 / 88
ui:isolated	🟢 0 · 🔴 0 · ⚪️ 0	0 / 8

This message was posted automatically by currents.dev | Integration Settings

blacksmith-sh · 2025-11-20T19:48:57Z

Found 3 test failures on Blacksmith runners:

Failures

Test	View Logs
`src/modules/data-table/tests/data-table-csv.controller.integration.test.ts/` `data-table-csv.controller.integration.test`	View Logs
`src/modules/data-table/tests/data-table-csv.controller.integration.test.ts/` `data-table-csv.controller.integration.test`	View Logs
`src/modules/data-table/tests/data-table-csv.controller.integration.test.ts/` `data-table-csv.controller.integration.test`	View Logs

RicardoE105

🚀

nikhilkuria added 2 commits November 11, 2025 14:10

feat: initial commit for csv export from data tables

d49388a

refactors in the service and controller

5d3d9c1

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 19, 2025

nikhilkuria added 2 commits November 19, 2025 18:51

minor refactors and safety checks

76c03e4

removing unwanted conversion of string

1ad9df0

nikhilkuria changed the title ~~feat: initial commit for csv export from data tables~~ feat(editor): CSV download support for data tables Nov 19, 2025

nikhilkuria added 2 commits November 19, 2025 19:27

remove unwanted conversion of string

a6561ed

resolving merge conflicts

9d105cc

nikhilkuria marked this pull request as ready for review November 19, 2025 18:32

Merge branch 'master' into feature-export-csv-data-tables

bbeab3d

cubic-dev-ai bot reviewed Nov 19, 2025

View reviewed changes

nikhilkuria added 2 commits November 19, 2025 19:49

add missing parameter

e5a4f9c

Merge branch 'feature-export-csv-data-tables' of https://github.com/n…

74760e0

…8n-io/n8n into feature-export-csv-data-tables

nikhilkuria requested review from a team and RicardoE105 November 19, 2025 18:54

RicardoE105 requested changes Nov 20, 2025

View reviewed changes

nikhilkuria and others added 5 commits November 20, 2025 14:04

removing comments

72e9e90

refactors and clean up

29eb2dd

adding integration test

fe90466

remove meaningless test

3215956

Merge branch 'master' into feature-export-csv-data-tables

3b86f72

RicardoE105 approved these changes Nov 21, 2025

View reviewed changes

	@ProjectScope('dataTable:read')
	@ProjectScope('dataTable:readRow')

feat(editor): CSV download support for data tables #22048

Are you sure you want to change the base?

feat(editor): CSV download support for data tables #22048

Conversation

nikhilkuria commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bundlemon bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

codecov bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

currents-bot bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blacksmith-sh bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

RicardoE105 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nikhilkuria commented Nov 19, 2025 •

edited

Loading

cubic-dev-ai bot Nov 19, 2025 •

edited

Loading

cubic-dev-ai bot Nov 19, 2025 •

edited

Loading

bundlemon bot commented Nov 19, 2025 •

edited

Loading

codecov bot commented Nov 19, 2025 •

edited

Loading

currents-bot bot commented Nov 20, 2025 •

edited

Loading

blacksmith-sh bot commented Nov 20, 2025 •

edited

Loading