fix(core): Add response validation for requests during DCR #22076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/cli/src/controllers/oauth/oauth2-credential.controller.ts">
<violation number="1" location="packages/cli/src/controllers/oauth/oauth2-credential.controller.ts:96">
The fallback grant type list no longer includes `refresh_token`, so when a server omits `grant_types_supported`, dynamic client registration now always fails with "No supported grant type" even though the server is compatible.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
…issing-response-validation
tomi
reviewed
Nov 20, 2025
Collaborator
tomi
left a comment
tomi
left a comment
There was a problem hiding this comment.
Thank you for improving this 🙇 Couple comments
packages/cli/src/controllers/oauth/oauth2-credential.controller.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/controllers/oauth/oauth2-credential.controller.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/controllers/oauth/oauth2-credential.controller.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/controllers/oauth/oauth2-credential.controller.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@tomi thanks for a thorough review 🙌 Addressed your comments and left replies to them |
…issing-response-validation
|
E2E Tests: n8n tests passed after 7m 8.8s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
…issing-response-validation
Contributor
Author
…issing-response-validation
…issing-response-validation
RomanDavydchuk
deleted the
node-3904-oauth2-dynamic-registration-is-missing-response-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)