-
Notifications
You must be signed in to change notification settings - Fork 51k
fix(Git Node): Throw an error if the repository path is blocked #22253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
|
E2E Tests: n8n tests passed after 9m 36.8s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
ShireenMissi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and the fix works as expected ✅
|
Got released with |
Summary
Check if the repository path is blocked before executing any commands. Default blocked paths include the
.n8nfolder, folders for custom nodes, config files, binary data storage path. This implementation uses existingisFilePathBlockedfunction that is used in other places, like Read/Write Files node. This way, the behavior is consistedRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3993/rce-via-arbitrary-file-write
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)