Skip to content

Conversation

@RomanDavydchuk
Copy link
Contributor

Summary

Check if the repository path is blocked before executing any commands. Default blocked paths include the .n8n folder, folders for custom nodes, config files, binary data storage path. This implementation uses existing isFilePathBlocked function that is used in other places, like Read/Write Files node. This way, the behavior is consisted

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-3993/rce-via-arbitrary-file-write

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review November 24, 2025 19:32
@Joffcom Joffcom requested a review from ShireenMissi November 24, 2025 19:32
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@currents-bot
Copy link

currents-bot bot commented Nov 24, 2025

E2E Tests: n8n tests passed after 9m 36.8s

🟢 588 · 🔴 0 · ⚪️ 12 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: c4dab1a

  • Spec files: 96

  • Overall tests: 600

  • Duration: 9m 36.8s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
ui 🟢 539 · 🔴 0 · ⚪️ 12 · 🟣 2 90 / 90
ui:isolated 🟢 49 · 🔴 0 · ⚪️ 0 6 / 6


This message was posted automatically by currents.dev | Integration Settings

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and the fix works as expected ✅

@n8n-assistant
Copy link

n8n-assistant bot commented Nov 26, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request release/backport Changes that need to be backported to older releases. release/backport-to-beta release/backport-to-stable Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants