Skip to content

Conversation

@oliverlambson
Copy link
Contributor

@oliverlambson oliverlambson commented Nov 15, 2025

Stacked on #788

Closes #784

Implements support for ADR-42


This is mostly a port of the implementation in nats.go – but adapted to try be in-line with the way things are done in nats.py.

@oliverlambson oliverlambson marked this pull request as draft November 15, 2025 16:04
@oliverlambson oliverlambson marked this pull request as ready for review November 15, 2025 16:17
@oliverlambson
Copy link
Contributor Author

oliverlambson commented Nov 15, 2025

As far as I can tell, the failing tests are unrelated to this PR and nats.py main will also fail those tests.

The current nats-server@main behaviour seems to be different to the 2.9-2.12 behaviour for StreamConfig: values like allow_direct are expected to be False but are coming back as None

#788 will fix this

@oliverlambson
Copy link
Contributor Author

@wallyqs @caspervonb any thoughts on this?

@oliverlambson oliverlambson force-pushed the js-consumer-groups branch 3 times, most recently from e07767b to 33960e4 Compare November 21, 2025 12:10
@oliverlambson oliverlambson changed the title Add jetstream consumer priority groups Add jetstream consumer priority groups (ADR-42) Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing support for jetstream consumer groups

1 participant