Skip to content

Conversation

@tinou98
Copy link
Contributor

@tinou98 tinou98 commented May 26, 2024

Expose 2 methods (key_value_store_names and key_value_stores) based on the existing streams & stream_names.

I added the option on stream & stream_names to filter the subject, but as a pub(crate) only. Maybe we should expose this publicly, but I don't know what the best API would be (stream_filtered or a Stream::subject like Purge::filter).

@Jarema
Copy link
Member

Jarema commented Jun 4, 2024

As this is not part of the KV ADR it would need to accepted by the maintainers first.

Will get back here after its discussed.

@Jarema
Copy link
Member

Jarema commented Jun 5, 2024

Hey. We agreed that this is a good idea.
When ADR will be updated, review of this one will happen.

Thanks!

@Jarema Jarema self-requested a review June 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants