-
Notifications
You must be signed in to change notification settings - Fork 14
Spawn custom images via kubespawner profiles #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
jbouder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just 1 thing.
| } | ||
| } | ||
| } | ||
| }, [serverTypes, currentFormInput, setCurrentFormInput]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing currentFormInput from this dependency array. Right now the useEffect may update that value, which can lead to infinite loops.
c471ada to
fa74a6d
Compare
jbouder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! My testing looks good.
Reference Issues or PRs
This is to be able to override default docker image for deploying an app.
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?