Skip to content

Conversation

@aktech
Copy link
Member

@aktech aktech commented Oct 15, 2025

Reference Issues or PRs

This is to be able to override default docker image for deploying an app.

Screenshot 2025-10-15 at 9 29 18 pm Screenshot 2025-10-15 at 9 29 56 pm

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jhub-apps Ready Ready Preview Comment Oct 21, 2025 9:54am
jhub-apps-docs Canceled Canceled Oct 21, 2025 9:54am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just 1 thing.

}
}
}
}, [serverTypes, currentFormInput, setCurrentFormInput]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing currentFormInput from this dependency array. Right now the useEffect may update that value, which can lead to infinite loops.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My testing looks good.

@aktech aktech merged commit f855918 into main Oct 21, 2025
26 checks passed
@aktech aktech deleted the aktech/add-kubespawner-image-ui branch October 21, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants