Connection Receive Timeout Configuration Hint Implementation #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transistive
requested changes
Nov 28, 2025
Collaborator
transistive
left a comment
transistive
left a comment
There was a problem hiding this comment.
Great work! I have some minor questions that we have to resolve. Let's also ensure static analysis is happy
| */ | ||
| public function discardUnconsumedResults(): void | ||
| { | ||
| if (!$this->isOpen()) { |
Collaborator
There was a problem hiding this comment.
Let's move this into the same if statement.
It is worth inspecting why we have to make this check, as if the conneciton is closed, the serverstate should not be in STREAMING or TX_STREAMING state in the first place
src/BoltFactory.php
Outdated
| $config->setServerAgent($response['server']); | ||
|
|
||
| // Apply recv_timeout hint if present | ||
| if (array_key_exists('connection.recv_timeout_seconds', $response['hints'])) { |
Collaborator
There was a problem hiding this comment.
This is a great subtle detail that we were able to pick up using the tests!
| $this->tsxConfig->getTimeout(), | ||
| $this->isInstantTransaction ? $this->bookmarkHolder : null, // let the begin transaction pass the bookmarks if it is a managed transaction | ||
| $this->isInstantTransaction ? $this->config->getAccessMode() : null, // let the begin transaction decide if it is a managed transaction | ||
| null, // mode is never sent in RUN messages - it comes from session configuration |
Collaborator
There was a problem hiding this comment.
Are we sure? $this->config is a session configuration object.
| TEST_DRIVER_REPO: /opt/project | ||
| TEST_BACKEND_HOST: testkit_backend | ||
| TEST_STUB_HOST: testkit | ||
| BOLT_LISTEN_ADDR: "0.0.0.0:9001" |
Collaborator
There was a problem hiding this comment.
Can you add a comment where this config variable is being used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection Receive Timeout Configuration Hint Implementation
BoltFactory Socket Timeout Application
Extracts connection.recv_timeout_seconds hint from server HELLO response
Applies timeout value to underlying socket connection via Connection::setTimeout()
Enables socket-level read timeouts on all authenticated connections
Timeout Exception Handling & Recovery
BoltMessage detects socket timeout exceptions and closes broken connections.
Converts timeout exceptions to Neo4jException with Neo.ClientError.Cluster.NotALeader error code
Session retry logic catches NotALeader errors and closes connection pool to force routing table refresh
Neo4jConnectionPool invalidates cached routing table, triggering fresh fetch from available servers
Implicitly marks timed-out server as unavailable and removes from routing table
Feature Declaration
GetFeatures declares support for ConfHint:connection.recv_timeout_seconds in testkit backend
Enables compliance testing against official Neo4j test suite