Skip to content

Conversation

@luisjira
Copy link
Member

Description

Regenerated Docs
FYI @gwynnemonahan

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (cad427a) to head (f137955).
⚠️ Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #2187      +/-   ##
================================================
- Coverage         73.99%   73.82%   -0.18%     
================================================
  Files                80       80              
  Lines              9096     9096              
================================================
- Hits               6731     6715      -16     
- Misses             1960     1970      +10     
- Partials            405      411       +6     
Flag Coverage Δ
unittests 73.82% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

memodi
memodi previously approved these changes Nov 24, 2025
Copy link
Member

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved QE has approved this pull request lgtm labels Nov 24, 2025
oliver-smakal
oliver-smakal previously approved these changes Nov 25, 2025
@luisjira luisjira mentioned this pull request Nov 25, 2025
10 tasks
@luisjira luisjira marked this pull request as draft November 25, 2025 10:50
@luisjira
Copy link
Member Author

I will open the PR again once the Grammar fix in #2189 is merged

@luisjira luisjira dismissed stale reviews from oliver-smakal and memodi via f137955 November 25, 2025 15:58
@openshift-ci openshift-ci bot removed the lgtm label Nov 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leandroberetta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luisjira luisjira marked this pull request as ready for review November 25, 2025 15:59
@jotak
Copy link
Member

jotak commented Nov 25, 2025

/lgtm

@luisjira luisjira merged commit 5b32823 into netobserv:release-1.10 Nov 26, 2025
9 of 10 checks passed
@luisjira luisjira deleted the release-1.10 branch November 26, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants