-
-
Notifications
You must be signed in to change notification settings - Fork 73
InjectExtension: added support for injecting services by tags #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rixafy
wants to merge
22
commits into
nette:v3.3
Choose a base branch
from
rixafy:inject-with-tags
base: v3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e952c3 to
b83c80a
Compare
…' moved to visitors
…st-class callables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added new method getByTypeAndTag (container + autowiring) so $throw can be always as last parameter, otherwise it would be getByType($type, $throw, $tag).
Now it's possible to have multiple services of the same type and inject them by tag with
#[Inject(tag: <tag>), it's also possible to use in constructors.Only rule is that one of those multiple services needs to have tag
default, and that service will be injected if no tag is specified (or if you specifydefault). I have considered also to inject service with least amount of tags or with no tags, but this can lead to unpredictable behavior when more tags are added in the future.This allows to work with interfaces and requiring specific services, some examples: