Skip to content

Fix pool matching when a server has no assigned pool #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pool matching when a server has no assigned pool #354

wants to merge 1 commit into from

Conversation

@aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Sep 12, 2017

There was a missing for-loop that caused a ReferenceError to be thrown.

@aleclarson
Fix pool matching when a server has no assigned pool
b071130 
There was a missing for-loop that caused a ReferenceError to be thrown.
@aleclarson
Copy link
Contributor Author

aleclarson commented Oct 27, 2017 •
edited
Loading

@neumino This PR should be merged ASAP.

It fixes a ReferenceError in PoolMaster.prototype.fetchServers (specifically this line where k is never defined).

@aleclarson
Copy link
Contributor Author

aleclarson commented Nov 24, 2017

When I get the chance, I'll add a test that breaks without this commit.

@thelinuxlich
Copy link

thelinuxlich commented May 23, 2018

merged in https://github.com/RebirthDB/rebirthdb-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aleclarson @thelinuxlich