-
Notifications
You must be signed in to change notification settings - Fork 95
feat(NcFilePicker): add picker component to select local files #7097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b222280 to
4d458d1
Compare
b9da927 to
7ba4e9e
Compare
b6f04d0 to
d11a3ab
Compare
d11a3ab to
f7320bd
Compare
|
@susnux is there anything you want to change here? I think you mentioned it at a meeting. |
Yes will work on it |
f7320bd to
b0e30d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7097 +/- ##
==========================================
+ Coverage 51.78% 52.11% +0.33%
==========================================
Files 98 100 +2
Lines 3171 3170 -1
Branches 874 873 -1
==========================================
+ Hits 1642 1652 +10
+ Misses 1279 1271 -8
+ Partials 250 247 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just to clarify: This is NOT the uploader. There will be a follow up with Current state of this PR is: I will add proper tests for this new component. |
2a9ae0e to
a660dd5
Compare
This can be used e.g. to upload files, for example in the forms app but also for the files or photos app. Signed-off-by: Ferdinand Thiessen <[email protected]>
a660dd5 to
be16ff5
Compare
| <!-- App defined upload actions --> | ||
| <slot name="actions" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much custom are the actions?
Would it be possible to replace the #actions slot with some props with menu lists:
- createNewOptions
- additionalOptions
where every option is a description:
- icon
- label
- callback
To avoid coupling on NcActions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #7882
Do you mean like I did there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
☑️ Resolves
This can be used e.g. to upload files, for example in the forms app but also for the files or photos app.
It is more universal than the upload picker from nc-upload as it is not bound to webdav uploader.
Just to clarify: This is NOT the uploader.
The idea here is that this is just a plain file picker (styled and enhanced
input[type=file].The use case are apps which have their own way of handling uploads - like forms - or if you directly process files in the browser.
There will be a follow up with
NcUploaderorNcUploadPicker(?) which will be the migrated component from@nextcloud/uploadand will be based on this component.🏁 Checklist
stable8for maintained Vue 2 version or not applicable