Skip to content

fixes #25296; get CPU arch from gcc #25297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
+7 −1
Open

fixes #25296; get CPU arch from gcc #25297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0aef5
fixes #25296; get CPU arch from gcc
demotomohiro Nov 19, 2025
2fe0d18
fixes gcc -dumpmachine call
demotomohiro Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/niminst/makefile.nimf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,13 @@ endif
target := ?{"$(binDir)/" & toLowerAscii(c.name)}


ucpu := $(shell sh -c 'uname -m | tr "[:upper:]" "[:lower:]"')
## get CPU arch from GCC instead of using `uname -m` as GCC target CPU arch can be different from uname.
## see #25296
## it should also get OS from GCC so that csource can be build with more GCC for cross compilation.
## but parsing OS name from `gcc -dumpmachine` is hard:
## https://wiki.osdev.org/Target_Triplet
ucpu := $(shell sh -c 'gcc -dumpmachine | cut --delimiter=- --field=1 | tr "[:upper:]" "[:lower:]"')
Copy link
Contributor

@bptato bptato Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long options are a GNUism so this won't work on FreeBSD etc. cut -d - -f 1 seems preferable.
Also, later down the file there's this line:

mycpu = $(shell /bin/sh -c '"$(CC)" -dumpmachine | sed "s/-.*//"')

clang supports dumpmachine too, so maybe $(CC) is better?

Copy link
Contributor Author

@demotomohiro demotomohiro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wasn't aware there is already code calls $(CC) -dumpmachine.

##ucpu := $(shell sh -c 'uname -m | tr "[:upper:]" "[:lower:]"')
ifeq ($(OS),Windows_NT)
uos := windows
else
Expand Down