Fixes #22 by using OS' certs instead of the hardcoded ones #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because Apple stopped accepting those Ref: nov/restclient_with_cert#1 Removed restclient_with_cert gem completely because it's no longer needed.
Author
|
@nov could you please review and merge it if it's all good. |
|
@guih you still have some dependencies on |
|
Any news on this? We're seeing it too. |
koedal
suggested changes
Mar 21, 2018
koedal
left a comment
koedal
left a comment
There was a problem hiding this comment.
Please also replace 'restclient_with_cert' from the require in the itunes.rb file also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22
Apple Store stopped accepting
restclient_with_certgem's hardcoded certs.So this replaces them by OS's own certs.
Ref: nov/restclient_with_cert#1
Removed
restclient_with_certgem completely because it's no longer needed.