Skip to content

Conversation

@merrcury
Copy link
Member

@merrcury merrcury commented Nov 5, 2025

This pull request introduces significant improvements to how regional context is handled for feature flagging and deployment, particularly with LaunchDarkly and AWS regions. The changes ensure that region information is consistently passed through both the frontend and backend, and expand deployment environment support to additional AWS regions.

Key changes include:

Feature flag context improvements:

  • The LaunchDarkly context in feature-flags-provider.tsx now includes a region object, with awsRegion dynamically detected from the URL and region config, and the context kind switched to 'multi' for better multi-dimensional targeting.
  • In identity-provider.tsx, user and organization identification for LaunchDarkly now includes the current region, using selectedRegion from context and getRegionConfig, ensuring LaunchDarkly receives accurate region data on user/org identification. [1] [2] [3] [4]
  • The LaunchDarkly service on the backend (launch-darkly.service.ts) now adds a region context if NOVU_REGION is set in the environment, aligning backend and frontend context structure.

Deployment workflow enhancements:

  • The GitHub Actions deployment workflow (deploy.yml) adds support for new AWS regions—London, Singapore, Australia, Japan, and Korea—across both staging and production, and updates environment mappings accordingly. [1] [2] [3]

Provider context composition fix:

  • The provider order in root.tsx was corrected so that IdentityProvider is now nested inside RegionProvider, ensuring region context is available when identifying users and organizations.

…y provider

- Added AWS region detection and configuration in feature flags provider.
- Updated identity provider to include region information when identifying users.
- Adjusted component hierarchy in root route for better context management.
@merrcury merrcury requested a review from scopsy November 5, 2025 17:07
@linear
Copy link

linear bot commented Nov 5, 2025

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 9d8b7a4
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/690b8437e020aa0008307871
😎 Deploy Preview https://deploy-preview-9455.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@scopsy scopsy closed this Nov 9, 2025
@scopsy scopsy reopened this Nov 9, 2025
@merrcury merrcury merged commit 49b9ac3 into next Nov 10, 2025
47 of 50 checks passed
@merrcury merrcury deleted the new-regions branch November 10, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants