Fix create_version_h.sh for out of tree builds #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building out of tree generated version.sh contains empty version. This patch fixes the issue by using subshell to change directory to the git tree from which cmake takes the sources. The fix only applies to building BCU on Posix compliant systems. Signed-off-by: Milosz Wasilewski <[email protected]>
wangxiaoningnxp
force-pushed
the
master
branch
3 times, most recently
from
3fac6bd to
48a1eb9
Compare
wangxiaoningnxp
force-pushed
the
master
branch
19 times, most recently
from
a09da4d to
ff12096
Compare
wangxiaoningnxp
force-pushed
the
master
branch
7 times, most recently
from
e372ea6 to
ed7028f
Compare
wangxiaoningnxp
force-pushed
the
master
branch
2 times, most recently
from
6e7d164 to
7a20b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building out of tree generated version.sh contains empty version. This patch fixes the issue by using subshell to change directory to the git tree from which cmake takes the sources. The fix only applies to building BCU on Posix compliant systems.