Editorial comments from Dan Moore #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editorial updates suggested by Dan Moore: See issue #236
PieterKas
requested review from
gffletch and
tulshi
and removed request for
tulshi
Added editorial updates and clarified scope changes.
gffletch
approved these changes
Nov 17, 2025
Collaborator
gffletch
left a comment
gffletch
left a comment
There was a problem hiding this comment.
I'm good with this PR. I did leave a comment about a line referencing replacement transaction tokens. I'm OK merging this PR and then cleaning up the replacement stuff in another PR.
Collaborator
Author
gffletch
approved these changes
Nov 18, 2025
Collaborator
gffletch
left a comment
gffletch
left a comment
There was a problem hiding this comment.
Are we good with putting normative requirements in the security considerations section?
Collaborator
Author
|
@gffletch - yes, I think it is OK to have normative language regarding security considerations. There was merge conflicts, so will need you to approve again before it can be merged (or if you can just merge it, it would be great). |
gffletch
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial updates suggested by Dan Moore: See issue #236