Add new patches to graphql-language-service and remove monaco-editor patch #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u9g
changed the title
obi1kenobi
reviewed
Oct 18, 2023
Owner
obi1kenobi
left a comment
obi1kenobi
left a comment
There was a problem hiding this comment.
Love the ideas for smarter autocomplete! Thanks for putting this together.
I think I might have found a few remaining edge cases before this is ready to merge and publish. Whenever you're able to take a look, I'll be happy to merge this.
| + // `state` is `null` when the user autocompletes after typing just '@' then opening autocomplete menu | ||
| + // further restrict the directives we suggest based on the type of the field we are on | ||
| + // x.label does not include the '@' | ||
| + if (primitives.has(typeInfo.fieldDef.type.name)) { |
Owner
There was a problem hiding this comment.
What happens here if the field type is something like [String!] or [[Int]]!?
Contributor
Author
There was a problem hiding this comment.
Amazing point, thank you! Then it will be an object of
{
"ofType": { // <- the list
"name": "String" // <- the actual type
}
}So the solution is just to iterate, done in 0f15fee
obi1kenobi
added
C-enhancement
obi1kenobi
reviewed
Oct 18, 2023
Don't check over each type's interface's interface's since the parent type must declare all interfaces implemented
obi1kenobi
force-pushed
the
main
branch
3 times, most recently
from
15f64a4 to
64ebfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remove the
monaco-editorpatch because it was the wrong fix, and we can just wait for the pr to land as it's just a console message.This pr adds:
... on XfragmentsFuture possibilities:
optype in@filter?