-
Notifications
You must be signed in to change notification settings - Fork 12
Add kidney volume terms for GWAS Catalog #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: ar-ibrahim <[email protected]>
Co-authored-by: ar-ibrahim <[email protected]>
…bels Co-authored-by: ar-ibrahim <[email protected]>
Co-authored-by: ar-ibrahim <[email protected]>
|
@copilot Normalize newly added OBA terms so that the new term IDs are at the end of the entity_attribute.tsv file. |
Co-authored-by: ar-ibrahim <[email protected]>
aleixpuigb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot has added the Uberon import manually into merged_import instead of into uberon_terms.txt. ATM, it can't do that, so you need to do it manually. I suggest to remove the changes in the file and then add the import locally.
…rrect labels" This reverts commit 7f8dd6c.
Manually refreshed imports for term UBERON:0006171 (renal sinus)
Fix equivalence class axiom error
| EquivalentClasses(<http://purl.obolibrary.org/obo/OBA_1000219> ObjectIntersectionOf(<http://purl.obolibrary.org/obo/PATO_0000001> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002314> <http://purl.obolibrary.org/obo/NBO_0000129>))) | ||
|
|
||
| # Class: <http://purl.obolibrary.org/obo/OBA_1000220> (serine family amino acid metabolic process quality) | ||
| # Class: <http://purl.obolibrary.org/obo/OBA_1000220> (obsolete serine family amino acid metabolic process quality) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GO has obsoleted serine family amino acid metabolic process and 2 other terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I ran the QC locally and working on fixing the obsoletions. The PR is still a draft.
Plan for Adding Kidney Volume Terms
Summary:
Successfully added three new kidney volume terms for GWAS Catalog:
All terms are now properly positioned at the end of entity_attribute.tsv file as requested.
Reference: PMID:41077127
Contributor: https://orcid.org/0000-0001-6757-4744
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.