Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

Plan for Adding Kidney Volume Terms

  • Investigate repository structure and patterns
  • Identify the appropriate DOSDP pattern (entity_attribute.tsv)
  • Verify UBERON IDs for anatomical structures
  • Add three new OBA terms to entity_attribute.tsv
  • Add UBERON:0006171 to merged_import.owl manually
  • Regenerate patterns/definitions.owl with correct labels
  • Verify all terms have proper definitions
  • Run security checks
  • Clean up tools/ directory from git tracking
  • Normalize term placement - move new terms to end of file
  • Final verification

Summary:
Successfully added three new kidney volume terms for GWAS Catalog:

  1. OBA:2100000 - kidney sinus volume
  2. OBA:2100001 - kidney medulla volume
  3. OBA:2100002 - kidney cortex volume

All terms are now properly positioned at the end of entity_attribute.tsv file as requested.

Reference: PMID:41077127
Contributor: https://orcid.org/0000-0001-6757-4744

Original prompt

This section details on the original issue you should resolve

<issue_title>NTR: kidney volume terms</issue_title>
<issue_description>New term requests for GWAS Catalog (kidney volume):

1- Kidney sinus volume
2- Kidney medulla volume
3- Kidney cortex volume

x-ref: PMID:41077127
orcid: https://orcid.org/0000-0001-6757-4744</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add new kidney volume terms for GWAS Catalog Add kidney volume terms for GWAS Catalog Nov 10, 2025
Copilot AI requested a review from ar-ibrahim November 10, 2025 13:58
Copilot finished work on behalf of ar-ibrahim November 10, 2025 13:58
@ar-ibrahim
Copy link
Collaborator

@copilot Normalize newly added OBA terms so that the new term IDs are at the end of the entity_attribute.tsv file.

Copy link
Contributor Author

Copilot AI commented Nov 10, 2025

@copilot Normalize newly added OBA terms so that the new term IDs are at the end of the entity_attribute.tsv file.

Done. The three new kidney volume terms (OBA:2100000, OBA:2100001, OBA:2100002) have been moved to the end of entity_attribute.tsv. Commit: 2f458e2

Copilot finished work on behalf of ar-ibrahim November 10, 2025 15:23
@ar-ibrahim ar-ibrahim marked this pull request as ready for review November 10, 2025 16:07
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot has added the Uberon import manually into merged_import instead of into uberon_terms.txt. ATM, it can't do that, so you need to do it manually. I suggest to remove the changes in the file and then add the import locally.

@ar-ibrahim ar-ibrahim marked this pull request as draft November 11, 2025 15:14
Manually refreshed imports for term UBERON:0006171 (renal sinus)
Fix equivalence class axiom error
EquivalentClasses(<http://purl.obolibrary.org/obo/OBA_1000219> ObjectIntersectionOf(<http://purl.obolibrary.org/obo/PATO_0000001> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002314> <http://purl.obolibrary.org/obo/NBO_0000129>)))

# Class: <http://purl.obolibrary.org/obo/OBA_1000220> (serine family amino acid metabolic process quality)
# Class: <http://purl.obolibrary.org/obo/OBA_1000220> (obsolete serine family amino acid metabolic process quality)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO has obsoleted serine family amino acid metabolic process and 2 other terms.

Copy link
Collaborator

@ar-ibrahim ar-ibrahim Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I ran the QC locally and working on fixing the obsoletions. The PR is still a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NTR: kidney volume terms

3 participants