-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Move Skill class to its own files #6322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FauziAkram
wants to merge
15
commits into
official-stockfish:master
Choose a base branch
from
FauziAkram:skillfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change
No functional change
No functional change
|
clang-format 20 needs to be run on this PR. (execution 17834744975 / attempt 1) |
No functional change
No functional change
No functional change
No functional change
No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Move Skill class to its own files
This pull request extracts the Skill struct and its associated implementation from search.h and search.cpp into new, dedicated files: skill.h and skill.cpp.
The Skill logic, which handles UCI strength limitation, is a distinct feature that is not core to the main search algorithm.
This change is offered as a suggestion, and I am happy to close this pull request if the maintainers prefer the current code structure.