Skip to content

Conversation

@mstembera
Copy link
Contributor

@mstembera mstembera commented Nov 5, 2025

Compile on MSVC got broken by #6173
No functional change
bench: 2626086

@anematode
Copy link
Contributor

How hard would it be to add MSVC to CI?

@mstembera
Copy link
Contributor Author

How hard would it be to add MSVC to CI?

We used to have it till #3800
It got removed because it failed once #3797 when the stack size wasn't adjusted properly.

No functional change
bench: 2626086
@vondele
Copy link
Member

vondele commented Nov 12, 2025

It is possible to add msvc to the github actions based ci https://github.com/ilammy/msvc-dev-cmd but I think we have very few users of that toolchain (1 I think ;-) )

@Matthies
Copy link
Contributor

MSVC Users: ||

@vondele vondele added the build label Nov 13, 2025
@vondele
Copy link
Member

vondele commented Nov 13, 2025

will merge, but can either 2 msvc users look into creating the ci action for it? Otherwise, it is unavoidable that we'll break it repeatedly, it really is not a setup we really care about.

@vondele vondele added the to be merged Will be merged shortly label Nov 13, 2025
@vondele vondele closed this in 8414858 Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build to be merged Will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants