[CI] Fix and extend E2E on PRs #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default 'issue_comment' trigger gets the context of a default branch. If we want to test the actual PR, on which we created/edited a comment we have to fetch and checkout a special ref for PR's merge commit. Note, that 'pull/<no>/merge' ref is available as long as the PR is not merged. This commit do not take this under consideration, since this case should be fairly uncommon and would obfuscate the workflow.
pbalcer
approved these changes
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 14.82% 12.51% -2.32%
==========================================
Files 250 239 -11
Lines 36220 35949 -271
Branches 4094 4076 -18
==========================================
- Hits 5369 4498 -871
- Misses 30800 31447 +647
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, E2E workflows don't run at all for PR's (triggered via comments), because git is failing to checkout proper ref.
Example of failed CI: https://github.com/oneapi-src/unified-runtime/actions/runs/8157313297/job/22296700396#step:5:60
// tested on my fork:
// https://github.com/lukaszstolarczuk/unified-runtime/actions/runs/8173691655/job/22346695074#step:5:29
// lukaszstolarczuk#5 (comment)