[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

SupunS · 2025-11-06T21:27:22Z

Work towards #3691

Depends on #4335

⚠️ DO NOT MERGE

Description

Use the generated static-type based subtyping check for the IsSubType() function (instead of the subtyping check based on sema-type)
Remove usages of MustConvertStaticToSemaType in VM, and rely on static-types.
Migrate some stdlib functions (e.g: Account related stdlib functions) to only use static-types (replace the usages of sema-type).

Results:

Vs VM in last released version (`v1.8.3`)

goos: darwin
goarch: arm64
pkg: github.com/onflow/cadence/runtime
cpu: Apple M1 Pro
                                 │ v1.8.3.txt  │             after.txt              │
                                 │   sec/op    │   sec/op     vs base               │
RuntimeFungibleTokenTransferVM-8   291.3µ ± 9%   273.0µ ± 4%  -6.27% (p=0.002 n=10)

                                 │  v1.8.3.txt  │              after.txt              │
                                 │     B/op     │     B/op      vs base               │
RuntimeFungibleTokenTransferVM-8   171.9Ki ± 0%   160.0Ki ± 0%  -6.92% (p=0.000 n=10)

                                 │ v1.8.3.txt  │              after.txt              │
                                 │  allocs/op  │  allocs/op   vs base                │
RuntimeFungibleTokenTransferVM-8   3.082k ± 0%   2.753k ± 0%  -10.67% (p=0.000 n=10)

Vs VM before switching to static-types (master)

goos: darwin
goarch: arm64
pkg: github.com/onflow/cadence/runtime
cpu: Apple M1 Pro
                                 │ before.txt  │             after.txt              │
                                 │   sec/op    │   sec/op     vs base               │
RuntimeFungibleTokenTransferVM-8   285.6µ ± 9%   273.0µ ± 4%  -4.40% (p=0.011 n=10)

                                 │  before.txt  │              after.txt              │
                                 │     B/op     │     B/op      vs base               │
RuntimeFungibleTokenTransferVM-8   170.6Ki ± 0%   160.0Ki ± 0%  -6.21% (p=0.000 n=10)

                                 │ before.txt  │             after.txt              │
                                 │  allocs/op  │  allocs/op   vs base               │
RuntimeFungibleTokenTransferVM-8   3.000k ± 0%   2.753k ± 0%  -8.23% (p=0.000 n=10)

**Note: The master branch also contains some optimizations that was ported over. So the above comparison only includes the improvement we get from switching to static-types only.

Vs Interpreter (master)

goos: darwin
goarch: arm64
pkg: github.com/onflow/cadence/runtime
cpu: Apple M1 Pro
                               │ interpreter.txt │           after.txt           │
                               │     sec/op      │   sec/op     vs base          │
RuntimeFungibleTokenTransfer-8       272.8µ ± 2%   273.0µ ± 4%  ~ (p=0.796 n=10)

                               │ interpreter.txt │              after.txt              │
                               │      B/op       │     B/op      vs base               │
RuntimeFungibleTokenTransfer-8      157.3Ki ± 0%   160.0Ki ± 0%  +1.70% (p=0.000 n=10)

                               │ interpreter.txt │             after.txt              │
                               │    allocs/op    │  allocs/op   vs base               │
RuntimeFungibleTokenTransfer-8       2.980k ± 0%   2.753k ± 0%  -7.62% (p=0.000 n=10)

Next steps

There are more stdlib functions that still needs to be updated to use only static-types.
Event emitting still need the sema types (hence the conversion exist). Should try to replace those as well.
Generated subtype check for static-types still converts to sema types in certain cases (for e.g: conformance information is not available in static-types, so need to convert to sema-type to get these information)

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

SupunS · 2025-11-06T21:29:31Z

interpreter/subtype_check.go

+	superTypeAccess := MustConvertStaticAuthorizationToSemaAccess(typeConverter, superTypeAuth)
+	subTypeAccess := MustConvertStaticAuthorizationToSemaAccess(typeConverter, subTypeAuth)
+	return sema.PermitsAccess(superTypeAccess, subTypeAccess)


This conversion is very expensive. We should try to address this next.

github-actions · 2025-11-06T21:32:50Z

Benchstat comparison

Base branch: onflow:feature/subtype-gen
Base commit: 19aeaaa

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileTime-4	33.3µs ± 0%	32.6µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	405µs ± 0%	413µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	191µs ± 0%	190µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	4.07ms ± 0%	5.16ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	257ns ± 0%	257ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	79.7ns ± 0%	77.9ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	120µs ± 0%	110µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	21.0µs ± 0%	26.3µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	13.5µs ± 0%	11.6µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-4	34.1µs ± 0%	32.3µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	16.3µs ± 0%	13.2µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	2.18ms ± 0%	2.46ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	112µs ± 0%	139µs ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	21.5µs ± 0%	27.4µs ± 0%	~	(p=1.000 n=1+1)
InterpreterNewStruct-4	62.3µs ± 0%	70.0µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	29.5µs ± 0%	27.2µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	50.9µs ± 0%	49.5µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	1.10µs ± 0%	1.02µs ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	314ns ± 0%	314ns ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	90.7µs ± 0%	82.4µs ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	33.8µs ± 0%	32.4µs ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	3.79µs ± 0%	3.70µs ± 0%	~	(p=1.000 n=1+1)
RecursionFib-4	826µs ± 0%	659µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	730µs ± 0%	785µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	593µs ± 0%	651µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	632µs ± 0%	592µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.60ms ± 0%	2.66ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	12.0ms ± 0%	12.0ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	15.3µs ± 0%	15.4µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	27.2µs ± 0%	23.9µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	70.2ns ± 0%	71.3ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileTime-4	16.3kB ± 0%	16.3kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	153kB ± 0%	155kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	73.5kB ± 0%	73.2kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	1.48MB ± 0%	1.54MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	38.4kB ± 0%	33.5kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	1.94kB ± 0%	1.94kB ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	21.8kB ± 0%	21.4kB ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	4.70kB ± 0%	4.36kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	39.9kB ± 0%	48.2kB ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	8.29kB ± 0%	8.29kB ± 0%	~	(all equal)
InterpreterNewStruct-4	24.4kB ± 0%	26.1kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	7.01kB ± 0%	6.98kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	14.5kB ± 0%	14.5kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	40.3kB ± 0%	40.0kB ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	10.4kB ± 0%	10.4kB ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	2.60kB ± 0%	2.59kB ± 0%	~	(p=1.000 n=1+1)
RecursionFib-4	88.1kB ± 0%	88.1kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	238kB ± 0%	259kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	159kB ± 0%	178kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	173kB ± 0%	163kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.27MB ± 0%	9.27MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.04kB ± 0%	8.04kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	9.80kB ± 0%	9.80kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileTime-4	176 ± 0%	176 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.46k ± 0%	2.53k ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	931 ± 0%	929 ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	39.0k ± 0%	41.0k ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	968 ± 0%	825 ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	49.0 ± 0%	49.0 ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	205 ± 0%	203 ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	86.0 ± 0%	84.0 ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	833 ± 0%	1003 ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	175 ± 0%	175 ± 0%	~	(all equal)
InterpreterNewStruct-4	418 ± 0%	448 ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	135 ± 0%	135 ± 0%	~	(all equal)
MethodCall/interface_method_call-4	285 ± 0%	285 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	722 ± 0%	720 ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	219 ± 0%	219 ± 0%	~	(all equal)
NewStructRaw-4	38.0 ± 0%	38.0 ± 0%	~	(all equal)
RecursionFib-4	3.65k ± 0%	3.65k ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	3.98k ± 0%	4.47k ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	2.98k ± 0%	3.41k ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	3.00k ± 0%	2.75k ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	159k ± 0%	159k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	113 ± 0%	113 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	197 ± 0%	197 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

…untime

This reverts commit d5cb8a2.

…untime

…-gen-runtime

… into supun/subtype-gen-runtime

SupunS added 6 commits November 5, 2025 15:31

Use static-types for VM subtype checks

576ed9a

Fix sema-type to static-type conversion

3307cb7

Implement missing subtyping checks for static-types

4a3cbfa

Some more minor optimizations

ac62b9f

Remove static-to-sema conversions from FT transfer execution path

cbf626b

Always call into the type-converter to convert from sema to static types

c9c944d

SupunS self-assigned this Nov 6, 2025

SupunS added the Improvement label Nov 6, 2025

SupunS commented Nov 6, 2025

View reviewed changes

Fix test-cases

37527c7

SupunS force-pushed the supun/subtype-gen-runtime branch from 493119f to 37527c7 Compare November 6, 2025 23:14

SupunS added 5 commits November 6, 2025 16:06

Cache authorization conversion results

fe176de

Merge branch 'supun/subtype-gen-9' into supun/subtype-gen-runtime

1f0e1f1

Add ConformingStaticTYpe

520f400

Cache typeID

3d8dc70

Customize the generated runtime subtype check to use sema types

e0130fc

SupunS mentioned this pull request Nov 10, 2025

[Subtyping Generator] Generate subtype check for runtime static-types #4327

Merged

6 tasks

SupunS added 2 commits November 10, 2025 11:29

Update generator

619bfa6

Merge branch 'supun/subtype-gen-statictypes' into supun/subtype-gen-r…

fb001cd

…untime

SupunS changed the base branch from feature/subtype-gen to supun/subtype-gen-statictypes November 10, 2025 19:33

SupunS added 3 commits November 10, 2025 12:38

Revert "Cache static-type IDs"

19d453d

This reverts commit d5cb8a2.

Remove temp files

ffd951d

Fix tests

13f8951

SupunS added the Performance label Nov 12, 2025

SupunS added 5 commits November 12, 2025 16:12

Merge branch 'supun/subtype-gen-statictypes' into supun/subtype-gen-r…

3e14b7e

…untime

Fix tests

c282550

Merge branch 'supun/subtype-gen-statictypes' into supun/subtype-gen-r…

34bd31f

…untime

Merge branch 'supun/subtype-gen-statictypes-tests' into supun/subtype…

a729ee1

…-gen-runtime

Fix tests

75b045c

SupunS changed the base branch from supun/subtype-gen-statictypes to supun/subtype-gen-statictypes-tests November 13, 2025 22:03

Base automatically changed from supun/subtype-gen-statictypes-tests to feature/subtype-gen November 14, 2025 20:43

SupunS added 2 commits November 14, 2025 14:43

Merge branch 'feature/subtype-gen' of https://github.com/onflow/cadence…

24ea3ec

… into supun/subtype-gen-runtime

Fix lint

ac573c0

SupunS force-pushed the supun/subtype-gen-runtime branch from 0107539 to ac573c0 Compare November 14, 2025 23:06

SupunS marked this pull request as ready for review November 14, 2025 23:14

SupunS requested review from RZhang05 and turbolent as code owners November 14, 2025 23:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

Uh oh!

SupunS commented Nov 6, 2025 •

edited

Loading

Uh oh!

SupunS Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

Are you sure you want to change the base?

[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

Uh oh!

Conversation

SupunS commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Results:

Vs VM in last released version (v1.8.3)

Vs VM before switching to static-types (master)

Vs Interpreter (master)

Next steps

Uh oh!

SupunS Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchstat comparison

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SupunS commented Nov 6, 2025 •

edited

Loading

Vs VM in last released version (`v1.8.3`)

github-actions bot commented Nov 6, 2025 •

edited

Loading