-
-
Notifications
You must be signed in to change notification settings - Fork 151
fix(shortbread): Update admin_points URL to GitHub repository #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Full logs: https://github.com/onthegomap/planetiler/actions/runs/19588638903 |
| admin_points: | ||
| type: shapefile | ||
| url: https://shortbread.geofabrik.de/shapefiles/admin-points-4326.zip | ||
| url: https://github.com/shortbread-tiles/shortbread-tilemaker/raw/refs/heads/main/data/admin-points-4326/admin_points.shp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay that won't work a zip'ed folder != shapefile
Any chance you might accept a .zip in this repo? @msbarry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably fine, but what exactly does that shapefile contain? Does tilekiln use it for osm.org or does it generate those points a different way? I'm wondering if it's strictly necessary.
On a side note it would probably be good to add shortbread to CI here to make sure you can always run it from scratch.



Geofabrik does not seem to supply this anymore.
@MichaelKreil Seems to have been smart and downloaded that to git.