feat(ofrep): add environment variable configuration #786
Conversation
erka
force-pushed
the
rd/ofrep
branch
3 times, most recently
from
090b8f0 to
2bb7de9
Compare
erka
changed the title
Add experimental WithFromEnv() option to configure the OFREP provider using environment variables. New features: - Add WithFromEnv() configuration option supporting: - OFREP_ENDPOINT: base URI for the OFREP service - OFREP_TIMEOUT: timeout duration (e.g., "30s", "500ms") - OFREP_API_KEY: API key for X-API-Key authentication - OFREP_BEARER_TOKEN: token for Bearer authentication - OFREP_HEADERS: comma-separated custom headers Signed-off-by: Roman Dmytrenko <[email protected]>
| // - OFREP_ENDPOINT: base URI for the OFREP service | ||
| // - OFREP_TIMEOUT: timeout duration (e.g., "30s", "1m" or raw "5000" in milliseconds ) | ||
| // - OFREP_HEADERS: comma-separated custom headers (e.g., "Key1=Value1,Key2=Value2") | ||
| func WithFromEnv() func(*outbound.Configuration) { |
There was a problem hiding this comment.
I like the cloud native approach of using EnvVar, but I think we should apply this by default. So when a user decides to set this, it will utilize those. The benefit is, that you can set this without a deployment and the usage of this variable.
The usual cloudnative approach is EnvVar -> setting -> default. https://github.com/open-feature/flagd-testbed/blob/main/gherkin/config.feature out lines this via gherkin files.
This is just a suggestion, not sure if this approach has been discussed or not :)
There was a problem hiding this comment.
@aepfli Could you please clarify what you mean? Should I append WithFromEnv() to the options when creating the OFREP provider?
Right now this is just a building block, so people can opt in if they want to use it like this
ofrep.NewProvider("https://default.endpoint", ofrep.WithFromEnv())This is similar to the OTEL approach. https://pkg.go.dev/go.opentelemetry.io/otel/sdk/resource#WithFromEnv
There was a problem hiding this comment.
@erka - based on the information provided I am now torn ;) - the cloud native way or at least how i interpret it (@toddbaert correct me if i am wrong) would be to append it, or do it automagically, to fallback to the env variables if there is not dedicated configuration.
This PR
Add experimental WithFromEnv() option to configure the OFREP provider using
environment variables.
Related Issues