-
Notifications
You must be signed in to change notification settings - Fork 834
chore: migrate from deprecated stale bot app to GitHub Actions stale action #4245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: JaydipGabani <[email protected]>
JaydipGabani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot address the feedback
.github/workflows/stale.yaml
Outdated
| with: | ||
| egress-policy: audit | ||
|
|
||
| - uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use commit for 10.1.0 tag and update the comment accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use the commit hash for v10.1.0 tag (5f858e3) and updated the comment accordingly in commit 7477b86.
Co-authored-by: JaydipGabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates stale issue and PR management from the deprecated stale bot app to the official GitHub Actions actions/stale workflow, as GitHub no longer maintains the bot app.
Key Changes:
- Replaces app-based configuration (
.github/stale.yml) with GitHub Actions workflow (.github/workflows/stale.yaml) - Extends stale management to include pull requests (previously only handled issues)
- Uses SHA-pinned action versions with security hardening via
step-security/harden-runner
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/stale.yaml |
New GitHub Actions workflow implementing stale issue/PR management with daily cron schedule, preserving all previous configuration values (60-day stale threshold, 14-day close threshold, exempt labels) |
.github/stale.yml |
Removed deprecated stale bot app configuration file |
|
Testing this workflow at - https://github.com/JaydipGabani/gatekeeper/actions/workflows/stale.yaml |
|
This action works for proof checkout closed issues and pr here - https://github.com/JaydipGabani/gatekeeper/issues |
Signed-off-by: Jaydip Gabani <[email protected]>
.github/workflows/stale.yaml
Outdated
|
|
||
| - uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10.1.0 | ||
| with: | ||
| days-before-stale: 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep 60?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, for some reason I thought we have 90 days as stale mark. Changed it to 60 days.
Signed-off-by: Jaydip Gabani <[email protected]>
What this PR does / why we need it:
Migrates stale issue/PR management from the deprecated stale bot app to the official
actions/staleGitHub Action (v10.1.0). The stale bot app is no longer maintained and GitHub recommends using the Actions-based approach..github/stale.yml(bot app config).github/workflows/stale.yaml(Actions workflow)actions/[email protected]with SHA-pinned commit hashubuntu-22.04runner, security hardening withstep-security/harden-runnerWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #4202
Special notes for your reviewer:
The workflow will not run until manually enabled or the first scheduled execution. Configuration is a direct 1:1 mapping from the old stale bot settings.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.