Skip to content

Conversation

@florianl
Copy link
Contributor

Description

Implement scraper for Profiles.

This will help implement receiver parts like open-telemetry/opentelemetry-collector-contrib#42843.

@florianl florianl requested a review from a team as a code owner September 29, 2025 09:08
@florianl florianl requested a review from dmitryax September 29, 2025 09:08
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl changed the title [scraper] add Profiles support [xscraper] add Profiles support Sep 29, 2025
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (116c181) to head (1ecee8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13915      +/-   ##
==========================================
- Coverage   92.15%   92.12%   -0.03%     
==========================================
  Files         663      666       +3     
  Lines       41387    41438      +51     
==========================================
+ Hits        38140    38176      +36     
- Misses       2211     2221      +10     
- Partials     1036     1041       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 14, 2025
@dmathieu dmathieu removed the Stale label Oct 14, 2025
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@dmitryax dmitryax added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Oct 23, 2025
florianl and others added 3 commits November 6, 2025 15:54
@florianl
Copy link
Contributor Author

florianl commented Nov 6, 2025

@dmitryax or @dmathieu - can this change get merged?

@mx-psi mx-psi added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@mx-psi
Copy link
Member

mx-psi commented Nov 19, 2025

Can you take a look at the failing tests?

Signed-off-by: Florian Lehner <[email protected]>
@florianl
Copy link
Contributor Author

@mx-psi make tidy seemed to resole the issue.

The error now seems to be receiver/expvarreceiver and unrelated to this change:

=== Failed
ERROR rerun aborted because previous run had a suspected panic and some test may not have run
=== FAIL: . TestLoadConfig/expvar/default (0.00s)

=== FAIL: . TestLoadConfig (0.00s)
panic: cannot handle unexported field at {*expvarreceiver.Config}.ClientConfig.Cookies.value:
		"go.opentelemetry.io/collector/config/configoptional".Optional[go.opentelemetry.io/collector/config/confighttp.CookiesConfig]
	consider using cmpopts.EquateComparable to compare comparable Go types [recovered]
	panic: cannot handle unexported field at {*expvarreceiver.Config}.ClientConfig.Cookies.value:
		"go.opentelemetry.io/collector/config/configoptional".Optional[go.opentelemetry.io/collector/config/confighttp.CookiesConfig]
	consider using cmpopts.EquateComparable to compare comparable Go types

goroutine 92 [running]:
testing.tRunner.func1.2({0x14167a0, 0xc00019a450})
	/opt/hostedtoolcache/go/1.24.10/x64/src/testing/testing.go:1734 +0x3eb
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.24.10/x64/src/testing/testing.go:1737 +0x696
panic({0x14167a0?, 0xc00019a450?})
	/opt/hostedtoolcache/go/1.24.10/x64/src/runtime/panic.go:792 +0x132
github.com/google/go-cmp/cmp.validator.apply({{}}, 0xc0003b3e00, {0x14a65e0?, 0xc000152720?, 0x1?}, {0x14a65e0?, 0xc000152ea0?, 0x1efe640?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/options.go:256 +0x66e
github.com/google/go-cmp/cmp.(*state).tryOptions(0xc0003b3e00, {0x1788cd0, 0x14a65e0}, {0x14a65e0?, 0xc000152720?, 0x4bee59?}, {0x14a65e0?, 0xc000152ea0?, 0x4c0ac9?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:306 +0x13a
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0003b3e00, {0x1772e90, 0xc000148d00})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:261 +0x729
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0003b3e00, {0x1788cd0, 0x151c280}, {0x151c280?, 0xc000152720?, 0x1?}, {0x151c280?, 0xc000152ea0?, 0x4c0ac9?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:414 +0xa09
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0003b3e00, {0x1772e90, 0xc000148700})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:289 +0x158c
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0003b3e00, {0x1788cd0, 0x1599e80}, {0x1599e80?, 0xc000152528?, 0x0?}, {0x1599e80?, 0xc000152ca8?, 0x4c0ac9?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:414 +0xa09
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0003b3e00, {0x1772e90, 0xc000148500})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:289 +0x158c
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0003b3e00, {0x1788cd0, 0x1500fe0}, {0x1500fe0?, 0xc000152508?, 0x32?}, {0x1500fe0?, 0xc000152c88?, 0x0?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:414 +0xa09
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0003b3e00, {0x1772f20, 0xc00032c7c0})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:289 +0x158c
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0003b3e00, {0x1788cd0, 0x147dbe0}, {0x147dbe0?, 0xc000152508?, 0x40?}, {0x147dbe0?, 0xc000152c88?, 0x4b7c60?})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:566 +0x7ef
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0003b3e00, {0x1772fb0, 0xc00032c780})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:295 +0x13d2
github.com/google/go-cmp/cmp.Diff({0x147dbe0, 0xc000152508}, {0x147dbe0, 0xc000152c88}, {0xc0002284e0, 0x2, 0x2})
	/home/runner/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:122 +0xc7
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/expvarreceiver.TestLoadConfig.func1(0xc000185a40)
	/tmp/contrib/receiver/expvarreceiver/config_test.go:88 +0x445
testing.tRunner(0xc000185a40, 0xc0000be820)
	/opt/hostedtoolcache/go/1.24.10/x64/src/testing/testing.go:1792 +0x226
created by testing.(*T).Run in goroutine 3
	/opt/hostedtoolcache/go/1.24.10/x64/src/testing/testing.go:1851 +0x8f3

DONE 24 tests, 2 failures in 1.066s
make[3]: *** [../../Makefile.Common:121: test] Error 3
make[2]: *** [Makefile:254: receiver/expvarreceiver] Error 2
make[1]: *** [Makefile:175: gotest] Error 2
make: *** [Makefile:214: check-contrib] Error 2

@mx-psi mx-psi added this pull request to the merge queue Nov 19, 2025
Merged via the queue into open-telemetry:main with commit 716e11a Nov 19, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants