Skip to content

Conversation

@rogercoll
Copy link
Contributor

Description

Adds support for profiles in the nop exporter, follow up of #14253

@rogercoll rogercoll requested review from a team and evan-bradley as code owners December 3, 2025 15:27
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #14254 will degrade performances by 75.94%

Comparing rogercoll:add_nop_exporter_profiles (475b4e3) with main (a0cbea7)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 1 regression
✅ 72 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
zstdWithConcurrency 6.9 µs 28.6 µs -75.94%

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (a0cbea7) to head (475b4e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14254      +/-   ##
==========================================
- Coverage   92.17%   92.16%   -0.01%     
==========================================
  Files         668      668              
  Lines       41467    41469       +2     
==========================================
  Hits        38221    38221              
- Misses       2213     2214       +1     
- Partials     1033     1034       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants