Skip to content

Added AlwaysRecordSampler #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added AlwaysRecordSampler #6732

wants to merge 1 commit into from

Conversation

@majanjua-amzn
Copy link

@majanjua-amzn majanjua-amzn commented Nov 27, 2025 •
edited
Loading

NOTE: WIP but ready for review, as design spec PR is still under review and close to being merged

Spec PR: open-telemetry/opentelemetry-specification#4699

Design discussion issue open-telemetry/opentelemetry-specification#4698

Changes

  • Add AlwaysRecordSampler that replaces any Drop sampling decision provided by a delegate sampler with RecordOnly
  • Added appropriate unit tests using the TestSampler as a delegate

Changes copied from the following with some modifications: aws-otel-dotnet-instrumentation

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@majanjua-amzn majanjua-amzn requested a review from a team as a code owner November 27, 2025 00:02
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Nov 27, 2025
Kielek
Kielek requested changes Nov 27, 2025
View reviewed changes
Copy link
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request change to avoid incidental merge.

For now, it is a specification proposal, it means we are not able to merge it even to the unstable releases.
If accepted as a development, needs to follow comments from #6617 (comment)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters documentation Documentation related labels Nov 27, 2025
@majanjua-amzn majanjua-amzn mentioned this pull request Nov 28, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kielek Kielek Kielek requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentation Documentation related infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majanjua-amzn @Kielek