Create placeholder for metrics common configuration #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 55.83% 56.27% +0.44%
==========================================
Files 255 255
Lines 22177 22180 +3
==========================================
+ Hits 12382 12482 +100
+ Misses 8956 8852 -104
- Partials 839 846 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grcevski
reviewed
Nov 28, 2025
| otel_traces_export: | ||
| endpoint: http://jaeger:4318 | ||
| meter_provider: | ||
| obi_features: |
Contributor
There was a problem hiding this comment.
why do we call them obi_features, instead of features?
Contributor
Author
There was a problem hiding this comment.
With the new changes, this is already: metrics > features
…nstrumentation into meter-provider
mariomac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation:
otel_metric_export > featuresto a commonmetrics > features, and deprecate itprometheus > featurestometrics > features, and deprecate itopentelemetry.iodocs as soon as the new property is accepted/agreed.The reason to move the features specification to a common section is because in the next PRs, we will allow a declarative per-service metric features definition. Having different metric features per export endpoint adds a lot of complexity to the code.