Skip to content

Conversation

@sonalgaud12
Copy link
Contributor

This PR fixes issue #8132

The WithMessageEvents option previously accepted an unexported type (event).
This change exports the type as Event.

@sonalgaud12 sonalgaud12 requested review from a team and dmathieu as code owners November 9, 2025 07:58
@sonalgaud12
Copy link
Contributor Author

Hello @dmathieu , OpenTelemetry Go enums usually prefix constants with the type name (e.g. SpanKindServer, SpanKindClient). So shall I change ReadEvents, WriteEvents to EventRead, EventWrite .

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.7%. Comparing base (8ef069f) to head (33a327d).

Files with missing lines Patch % Lines
instrumentation/net/http/otelhttp/config.go 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8153     +/-   ##
=======================================
- Coverage   81.8%   81.7%   -0.1%     
=======================================
  Files        194     194             
  Lines      13362   13362             
=======================================
- Hits       10931   10920     -11     
- Misses      2033    2044     +11     
  Partials     398     398             
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/config.go 82.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant