Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 8, 2025

No description provided.

@MrAlias MrAlias added this to the v1.40.0 milestone Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (e5b89b0) to head (9928aed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8266   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        194     193    -1     
  Lines      13798   13780   -18     
=====================================
- Hits       11357   11345   -12     
+ Misses      2033    2030    -3     
+ Partials     408     405    -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review December 8, 2025 22:10
@MrAlias MrAlias requested a review from dmathieu as a code owner December 8, 2025 22:10
Copilot AI review requested due to automatic review settings December 8, 2025 22:10
@MrAlias MrAlias requested a review from a team as a code owner December 8, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated DefaultClient, Get, Head, Post, and PostForm convenience functions from the otelhttp package. These functions were previously marked as deprecated, and users are now expected to create their own *http.Client using otelhttp.NewTransport(http.DefaultTransport) for HTTP client instrumentation.

  • Complete removal of deprecated client convenience wrapper functions
  • Removal of associated test coverage for the deprecated functions
  • CHANGELOG entry documenting the breaking change

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
instrumentation/net/http/otelhttp/client.go Removes the entire file containing DefaultClient variable and Get, Head, Post, and PostForm convenience functions
instrumentation/net/http/otelhttp/client_test.go Removes all tests for the deprecated client convenience functions
CHANGELOG.md Adds entry in the "Removed" section documenting the breaking change with migration guidance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MrAlias MrAlias merged commit 61a249e into open-telemetry:main Dec 9, 2025
35 of 45 checks passed
@MrAlias MrAlias deleted the rm-dep-otelhttp-client branch December 9, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants