-
Notifications
You must be signed in to change notification settings - Fork 708
Remove the deprecated otelhttp Client
#8266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8266 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 194 193 -1
Lines 13798 13780 -18
=====================================
- Hits 11357 11345 -12
+ Misses 2033 2030 -3
+ Partials 408 405 -3 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the deprecated DefaultClient, Get, Head, Post, and PostForm convenience functions from the otelhttp package. These functions were previously marked as deprecated, and users are now expected to create their own *http.Client using otelhttp.NewTransport(http.DefaultTransport) for HTTP client instrumentation.
- Complete removal of deprecated client convenience wrapper functions
- Removal of associated test coverage for the deprecated functions
- CHANGELOG entry documenting the breaking change
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
instrumentation/net/http/otelhttp/client.go |
Removes the entire file containing DefaultClient variable and Get, Head, Post, and PostForm convenience functions |
instrumentation/net/http/otelhttp/client_test.go |
Removes all tests for the deprecated client convenience functions |
CHANGELOG.md |
Adds entry in the "Removed" section documenting the breaking change with migration guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.