Skip to content

Conversation

@vitorvasc
Copy link
Member

@vitorvasc vitorvasc commented Nov 21, 2025

Preview: https://deploy-preview-8479--opentelemetry.netlify.app/

/cc @chalin @svrnm


For the list of officially supported emojis, see https://gohugo.io/quick-reference/emojis/

@vitorvasc vitorvasc requested a review from a team as a code owner November 21, 2025 09:36
@vitorvasc vitorvasc added the docs:CI/infra CI & infrastructure label Nov 21, 2025
@svrnm
Copy link
Member

svrnm commented Nov 21, 2025

hm... my understanding would be that by enableEmojify this works out of the box? So no changes to the shortcodes are required, or do I misread something in their docs:

https://gohugo.io/quick-reference/emojis/

@chalin
Copy link
Contributor

chalin commented Nov 21, 2025

Let me take a look once I'm done debugging the pt/pt-br i18n bundle issue.
(Btw, the alert shortcode from this repo is going away very soon since Docsy provides the one we want to use.)

@vitorvasc
Copy link
Member Author

hm... my understanding would be that by enableEmojify this works out of the box? So no changes to the shortcodes are required, or do I misread something in their docs:

gohugo.io/quick-reference/emojis

I added the enableEmojify property to the config file and ran a couple tests, emojis on regular pages worked fine, but the alert shortcode was still rendering them as plain text.

Further down in the same Hugo docs page, there's a note about this:

To process an emoji shortcode from within a template, use the emojify function or pass the string through the RenderString method on a Page object

So my last test was adding the emojify function to the alerts shortcode, and that's when it started working. Ideally, it'd be great if enableEmojify handled this automatically, otherwise we might need to update all shortcodes to ensure emojis will render correctly. 🤔

@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

@vitorvasc - can you rebase, update the opening comment, and add a preview link (or a few) to the opening commment?

@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

Maybe we can do this in stages. Start by enabling the feature and then deal with alerts after.

@vitorvasc vitorvasc force-pushed the vitorvasc_enable-emoji-hugo-build branch from c42204e to e34b819 Compare November 26, 2025 19:55
@vitorvasc
Copy link
Member Author

@chalin I've rebased and updated the opening comment — but I couldn't find any page that uses a non-UTF-8 emoji besides the one with the alert. 🤔

@chalin chalin force-pushed the vitorvasc_enable-emoji-hugo-build branch from e34b819 to 0141889 Compare November 26, 2025 21:24
@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

What is the link to that page?

@vitorvasc
Copy link
Member Author

What is the link to that page?

It's this one: https://deploy-preview-8479--opentelemetry.netlify.app/community/end-user/#contact

@otelbot-docs otelbot-docs bot requested a review from a team November 26, 2025 22:24
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once all checks pass.

@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

Editorial change to end-user page, so I'll schedule this for merging when ready. /cc @open-telemetry/sig-end-user-approvers

@chalin chalin enabled auto-merge November 26, 2025 22:26
@chalin chalin added this pull request to the merge queue Nov 26, 2025
Merged via the queue into open-telemetry:main with commit edf9b8e Nov 26, 2025
22 checks passed
@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

And emojis are enabled, including inside alerts:

image

@chalin
Copy link
Contributor

chalin commented Nov 26, 2025

And in spec pages, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:CI/infra CI & infrastructure sig:enduser

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Enable emojis in docs builds

3 participants