Skip to content

Fix: Assign consistent colors to all forecast models in utils.py #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnujNayak108 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix: Assign consistent colors to all forecast models in utils.py #375

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78a5be3
Fix: Assign consistent colors to all forecast models in utils.py
AnujNayak108 Oct 6, 2025
3426eb5
Merge branch 'main' into model-color-fix
AnujNayak108 Oct 6, 2025
d8748ec
remove commented-out code and unused lines
AnujNayak108 Oct 15, 2025
5543b2e
Merge branch 'model-color-fix' of https://github.com/AnujNayak108/ana…
AnujNayak108 Oct 15, 2025
f116d18
keep PVLive colour white as before
AnujNayak108 Oct 17, 2025
f006b7e
changed line_color to get_colour_from_model_name in required files
AnujNayak108 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions src/plots/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,9 @@
from nowcasting_datamodel.read.read_models import get_models
import os
from datetime import datetime, timedelta
import plotly.express as px

line_color = [
"#9EC8FA",
"#9AA1F9",
"#FFAC5F",
"#9F973A",
"#7BCDF3",
"#086788",
"#63BCAF",
"#4C9A8E",
]
PALETTE = px.colors.qualitative.Dark24

colour_per_model = {
"cnn": "#FFD053",
Expand All @@ -28,7 +20,6 @@

# Make a cycle for extra models not in colour_per_model
# Skip first 3 colours as they are too similar to colours in colour_per_model
Copy link
Member

@Sukh-P Sukh-P Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be removed too as the line it related to has been removed

Copy link
Contributor Author

@AnujNayak108 AnujNayak108 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

line_color_cycle = cycle(line_color[3:])

def hex_to_rgb(value):
value = value.lstrip("#")
Expand All @@ -39,14 +30,15 @@ def hex_to_rgb(value):
def get_colour_from_model_name(model_name, opacity=1.0):
"""Get colour from model label"""
if "PVLive" in model_name:
colour = colour_per_model.get(model_name, "#FFFFFF")
return colour_per_model.get(model_name, "#FFFFFF")
else:
# Some models have a space and a datetime
model_name_only = model_name.split(" ")[0]
if model_name_only in colour_per_model:
colour = colour_per_model[model_name_only]
else:
colour = next(line_color_cycle)
idx = abs(hash(model_name_only)) % len(PALETTE)
colour = PALETTE[idx]
colour_per_model[model_name_only] = colour
return colour

Expand Down