Skip to content

Conversation

@chambridge
Copy link
Contributor

@chambridge chambridge commented Nov 5, 2025

Description

Add IMAGES_POSTGRES to RELATED_IMAGE_RHEL9_POSTGRES16_IMAGE mapping in model registry image replacement configuration to support PostgreSQL 16 container image deployment.

Related PRs:

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has run the integration test pipeline and verified that it passed successfully

E2E test suite update requirement

When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.

To opt-out of this requirement:

  1. Please inspect the opt-out guidelines, to determine if the nature of the PR changes allows for skipping this requirement
  2. If opt-out is applicable, provide justification in the dedicated E2E update requirement opt-out justification section below
  3. Check the checkbox below:
  • Skip requirement to update E2E test suite for this PR
  1. Submit/save these changes to the PR description. This will automatically trigger the check.

E2E update requirement opt-out justification:

This PR adds a simple environment variable mapping (IMAGES_POSTGRES)
to the ModelRegistry component's imagesMap without changing any functional
behavior of the operator. The change:

This is purely an infrastructure change to support downstream component
configuration and does not warrant E2E test coverage at the operator level.

Summary by CodeRabbit

  • New Features
    • Added support for PostgreSQL 16 container image in the model registry's image references, improving database image selection and deployment compatibility.

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Walkthrough

Adds a single image mapping entry to the model registry support: maps "IMAGES_POSTGRES" to "RELATED_IMAGE_POSTGRESQL_16_IMAGE" in imagesMap; no other logic or API surface changes.

Changes

Cohort / File(s) Summary
Image registry mapping expansion
internal/controller/components/modelregistry/modelregistry_support.go
Adds a new key-value entry to imagesMap: "IMAGES_POSTGRES""RELATED_IMAGE_POSTGRESQL_16_IMAGE" (PostgreSQL 16 image reference)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line mapping addition; no control-flow, validation, or dependency changes.

Poem

🐰 I hopped through code with gentle paws,
A postgres name I tucked in clause,
Sixteen’s now known where images stay,
A tiny map, a brighter day. 🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a PostgreSQL 16 image mapping to the model registry configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 942580d and 12797fb.

📒 Files selected for processing (1)
  • internal/controller/components/modelregistry/modelregistry_support.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • internal/controller/components/modelregistry/modelregistry_support.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build/push catalog image
  • GitHub Check: kube-linter
  • GitHub Check: golangci-lint
  • GitHub Check: Run tests and collect coverage on internal and pkg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.07%. Comparing base (0e1522c) to head (d33ec3d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2812   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files         144      144           
  Lines       10469    10469           
=======================================
  Hits         5242     5242           
  Misses       4669     4669           
  Partials      558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added approved and removed lgtm labels Nov 6, 2025
@chambridge chambridge force-pushed the chore/add-postgres-image-mapping branch from f125ab8 to 942580d Compare November 6, 2025 13:54
@chambridge chambridge marked this pull request as ready for review November 6, 2025 13:54
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: riprasad, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chambridge and others added 2 commits November 6, 2025 11:02
Add IMAGES_POSTGRES to RELATED_IMAGE_RHEL9_POSTGRES16_IMAGE mapping
in model registry image replacement configuration to support PostgreSQL
16 container image deployment.

Related: opendatahub-io/model-registry-operator#374

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Chris Hambridge <[email protected]>
@chambridge chambridge force-pushed the chore/add-postgres-image-mapping branch from 942580d to 12797fb Compare November 6, 2025 16:02
@openshift-ci openshift-ci bot removed the lgtm label Nov 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

New changes are detected. LGTM label has been removed.

@chambridge
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

@chambridge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e-hypershift 7716daa link false /test opendatahub-operator-e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chambridge
Copy link
Contributor Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants