RHOAIENG-38505 | build: update image placeholder strategy

Makefile

@@ -278,7 +278,7 @@ prepare: manifests kustomize manager-kustomization
 manager-kustomization: config/manager/kustomization.yaml.in
 	cd config/manager \
 		&& cp -f kustomization.yaml.in kustomization.yaml \
-		&& $(KUSTOMIZE) edit set image controller=$(IMG)
+		&& $(KUSTOMIZE) edit set image REPLACE_IMAGE=$(IMG)
 
 .PHONY: install
 install: prepare ## Install CRDs into the K8s cluster specified in ~/.kube/config.

config/manager/kustomization.yaml.in

@@ -6,6 +6,3 @@ generatorOptions:
 
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
-images:
-- name: controller
-  newName: REPLACE_IMAGE

config/manager/manager.yaml

@@ -72,7 +72,8 @@ spec:
         args:
         - --leader-elect
         - --operator-name=opendatahub
-        image: controller:latest
+        # NOTE: image is provided in CI by pullspec substitution, and by make/kustomize for local builds
+        image: REPLACE_IMAGE:latest
         imagePullPolicy: Always
         name: manager
         ports: