Skip to content

fix: Remove horizontal scroll on instructor page in RTL version #36335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

fix: Remove horizontal scroll on instructor page in RTL version #36335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d7df66
fix: Remove horizontal scroll on instructor page in RTL version
Lunyachek Mar 6, 2025
3eaa950
fix: After review
Lunyachek Jul 2, 2025
139f5f7
fix: Changes after review
Lunyachek Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lms/static/sass/course/instructor/_instructor_2.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,16 +708,14 @@
.hint {
@extend %t-copy-sub2;

display: block;
display: none;
position: absolute;
top: ($baseline/2);

@include left(-9999em);

padding: ($baseline/2);
width: 50%;
background-color: $light-gray3;
box-shadow: 2px 2px 3px $shadow;
z-index: 1;

.hint-caret {
display: block;
Expand All @@ -736,11 +734,10 @@
/* ***
* Ideally we want to handle functionality with JS.
* This functionality should eventually be moved into CS/JS, and out of here. */
.has-hint:hover > .hint {
@include left($baseline*10);
}

.has-hint:hover > .hint,
.has-hint input:focus ~ .hint {
Copy link
Member

@OmarIthawi OmarIthawi Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need display block here, right?

Copy link
Contributor

@sarina sarina Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lunyachek can you address this comment?

Copy link
Contributor Author

@Lunyachek Lunyachek Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmarIthawi Yes, you’re absolutely right. I’ve added display: block

display: block;

@include left($baseline*10);
}

Expand Down
Loading