-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[DO NOT MERGE] chore!: replace pytz with zoneinfo #37148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[DO NOT MERGE] chore!: replace pytz with zoneinfo #37148
Conversation
chintanjoshi-apphelix-2u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is a big change. It'd be difficult to review as well as test. So this can be broken down into multiple parts
What can be done instead is,
- Core changes go first
- Then we start by each app (i.e. lms,cms .. etc)
- Then with the
.htmlfiles (Which might be not needed as lots of files are being removed and replaced with MFEs) - And the last stage we remove
pytzdependency from requirements.
This will help in testing as well. Because testing these altogether is a bit difficult.
Also, there needs to be some discussion and some noise around this as well ? Because this change is something that is affecting whole platform. Tickets and DEPRs may exist around it, if so we can link those, if not we can start creating some noise around it. Basically this should not go as a whole without some discussion around it.
chore!: replace pytz with zoneinfo