Skip to content

Conversation

@ttak-apphelix
Copy link
Contributor

chore!: replace pytz with zoneinfo

@ttak-apphelix ttak-apphelix changed the title chore!: replace pytz with zoneinfo [DO NOT MERGE] chore!: replace pytz with zoneinfo Aug 14, 2025
@ttak-apphelix ttak-apphelix marked this pull request as ready for review August 14, 2025 12:04
@ttak-apphelix ttak-apphelix requested review from a team as code owners August 14, 2025 12:04
@ttak-apphelix ttak-apphelix removed request for a team August 14, 2025 12:04
Copy link

@chintanjoshi-apphelix-2u chintanjoshi-apphelix-2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttak-apphelix

I believe that this is a big change. It'd be difficult to review as well as test. So this can be broken down into multiple parts

What can be done instead is,

  • Core changes go first
  • Then we start by each app (i.e. lms,cms .. etc)
  • Then with the .html files (Which might be not needed as lots of files are being removed and replaced with MFEs)
  • And the last stage we remove pytz dependency from requirements.

This will help in testing as well. Because testing these altogether is a bit difficult.

Also, there needs to be some discussion and some noise around this as well ? Because this change is something that is affecting whole platform. Tickets and DEPRs may exist around it, if so we can link those, if not we can start creating some noise around it. Basically this should not go as a whole without some discussion around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants