-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[FC-0099] feat: Upgrade Python dependency openedx-authz #37652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27baa39 to
07b5525
Compare
Member
|
@MaferMazu: do you have the diff between the queries executed before and after this change? If those make sense, we can merge this as is and document why the query count increased. Thank you so much! |
Contributor
|
Yes, @mariajgrimaldi, I just added them to the cover, but the difference is those 5 queries:
|
handle cache invalidation Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
07b5525 to
92a91f2
Compare
mariajgrimaldi
approved these changes
Nov 19, 2025
MaferMazu
added a commit
to eduNEXT/edx-platform
that referenced
this pull request
Nov 19, 2025
* feat: Upgrade Python dependency openedx-authz handle cache invalidation Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` * fix: update the num of queries in tests --------- Co-authored-by: MaferMazu <[email protected]> Co-authored-by: Maria Fernanda Magallanes Zubillaga <[email protected]> (cherry picked from commit 122b4e0)
MaferMazu
added a commit
to eduNEXT/edx-platform
that referenced
this pull request
Nov 19, 2025
* feat: Upgrade Python dependency openedx-authz handle cache invalidation Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` * fix: update the num of queries in tests --------- Co-authored-by: MaferMazu <[email protected]> Co-authored-by: Maria Fernanda Magallanes Zubillaga <[email protected]> (cherry picked from commit 122b4e0)
mariajgrimaldi
added a commit
that referenced
this pull request
Nov 20, 2025
…cement points (#37633) * feat: filter libraries based on user-role scopes (#37564) (cherry picked from commit 6c6fc5d) * feat: add openedx-authz to user_can_create_library and require_permission_for_library_key (#37501) * feat: add the authz check to the library api function feat: add the authz publish check in rest_api blocks and containers feat: add the authz checks in libraries and refactor feat: add collections checks feat: update enforcement in serializer file refactor: refactor the permission check functions fix: fix value error fix: calling the queries twice * test: add structure for test and apply feedback refactor: refactor the tests and apply feedback fix: apply feedback Revert "refactor: refactor the tests and apply feedback" This reverts commit aa0bd52. refactor: use constants and avoid mapping test: fix the test to have them in order docs: about we rely on bridgekeeper and the old check for two cases docs: update openedx/core/djangoapps/content_libraries/api/libraries.py Co-authored-by: Maria Grimaldi (Majo) <[email protected]> refactor: use global scope wildcard instead of * refactor: allow receiving PermissionData objects refactor: do not inherit from BaseRolesTestCase to favor CL setup methods If both BaseRolesTestCase and ContentLibrariesRestApiTest define a method with the same name (e.g., setUp()), Python will use the one found first in the MRO, which is the one in BaseRolesTestCase because it is listed first in the class definition leading to unexpected behavior. refactor: remove unnecessary imports and indent * chore: bump openedx-authz version (cherry picked from commit f4f14a6) * feat: Upgrade Python dependency openedx-authz (#37652) * feat: Upgrade Python dependency openedx-authz handle cache invalidation Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` * fix: update the num of queries in tests --------- Co-authored-by: MaferMazu <[email protected]> Co-authored-by: Maria Fernanda Magallanes Zubillaga <[email protected]> (cherry picked from commit 122b4e0) * chore: update requirements to fix the inconsistency --------- Co-authored-by: Maria Grimaldi (Majo) <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from v0.17.1 to 0.19.0:
Handle cache invalidation via a uuid in the database to ensure policy reloads
occur only when necessary.
Migration to transfer legacy permissions from ContentLibraryPermission to the new Casbin-based authorization model.
More info: https://github.com/openedx/openedx-authz/blob/main/CHANGELOG.rst
Those changes add five more queries to retrieve permissions for tags and taxonomies, so I changed
test_object_tags_query_countandtest_list_taxonomy_query_count, respectively. The queries added are the following: