Skip to content

Conversation

@Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Oct 21, 2025

  1. Modifying users is already handled by the LMS retirement pipeline. The forum library should not alter LMS users during retirement.
  2. Changing the email to an empty string results in integrity errors in the MySQL backend, because the email must be unique.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 21, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 21, 2025
@Agrendalath Agrendalath requested review from a team October 21, 2025 10:38
@Agrendalath Agrendalath force-pushed the agrendalath/fix-retirement-pipeline branch from e6eba26 to f48c948 Compare October 21, 2025 10:42
1. Modifying users is already handled by the LMS retirement pipeline.
The `forum` library should not alter LMS users during retirement.
2. Changing the email to an empty string results in integrity errors
in the MySQL backend, because the email must be unique.
@Agrendalath Agrendalath force-pushed the agrendalath/fix-retirement-pipeline branch from f48c948 to 35ec3e1 Compare October 21, 2025 10:51
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 22, 2025
@ormsbee ormsbee self-requested a review November 19, 2025 18:34
@ormsbee ormsbee self-assigned this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants