-
Notifications
You must be signed in to change notification settings - Fork 8
Introduce courseNavigationBar on header slot #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Introduce courseNavigationBar on header slot #106
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| if (selectedUrl.startsWith('http://') || selectedUrl.startsWith('https://')) { | ||
| const url = new URL(selectedUrl); | ||
| if (url.origin === window.location.origin) { | ||
| navigate(url.pathname + url.search + url.hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to use navigate as much as possible so we can preserve app state and avoid unneeded full page load
114be5d to
a79f6cf
Compare
a79f6cf to
45c11fe
Compare
e883f25 to
4536f10
Compare
| ))} | ||
| </Tabs> | ||
| </div> | ||
| <Slot id="org.openedx.frontend.slot.header.courseNavigationBar.extraContent.v1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This slot was added because on current learning MFE this nav bar has some extra content related to courseware search
4536f10 to
26b19ea
Compare
|
@arbrandes do you remember which FWG meeting we discussed this in? I think I need to look through our discussion to remember how the "render conditionally based on role" part is supposed to work (IIRC we talked about apps having roles associated?) |
we discussed it on this one https://openedx.atlassian.net/wiki/spaces/COMM/pages/5255593985/2025-10-09+Frontend+Working+Group+Meeting+Notes+Shai-Hulud+Program+Dashboard+etc For now i didn't introduce anything related to roles and just abstract how is working now (retrieving the enabled tabs from the course-metadata endpoint) |
Description
As part of the conversion of MFEs to frontend base, we figured it out that 3 different repos will need Course Navigation Bar (Learning, Discussions and Instructor), so instead of having repetitive code on 3 different repos we come up with the following approach:
Screenshot