Skip to content

Conversation

@diana-villalvazo-wgu
Copy link

@diana-villalvazo-wgu diana-villalvazo-wgu commented Oct 15, 2025

Description

As part of the conversion of MFEs to frontend base, we figured it out that 3 different repos will need Course Navigation Bar (Learning, Discussions and Instructor), so instead of having repetitive code on 3 different repos we come up with the following approach:

  • Moving Course Navigation Tab bar to frontend-base as a slot inside the header and adding the roles where this new slot will be active.
  • We need to get courseId (now we are grabbing it from current location) and make a request using react-query to gather correct course metadata (contains tabs info).
  • We added an slot for extra content in case MFE needs to add it (current use case: Learning MFE, courseware search).

Screenshot

Screenshot 2025-10-15 at 5 31 16 p m

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 15, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 15, 2025

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 15, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Oct 15, 2025
if (selectedUrl.startsWith('http://') || selectedUrl.startsWith('https://')) {
const url = new URL(selectedUrl);
if (url.origin === window.location.origin) {
navigate(url.pathname + url.search + url.hash);
Copy link
Author

@diana-villalvazo-wgu diana-villalvazo-wgu Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to use navigate as much as possible so we can preserve app state and avoid unneeded full page load

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the courseNavigationBar branch 3 times, most recently from 114be5d to a79f6cf Compare October 16, 2025 18:33
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 16, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the courseNavigationBar branch 2 times, most recently from e883f25 to 4536f10 Compare October 20, 2025 22:18
))}
</Tabs>
</div>
<Slot id="org.openedx.frontend.slot.header.courseNavigationBar.extraContent.v1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slot was added because on current learning MFE this nav bar has some extra content related to courseware search

@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review October 20, 2025 22:20
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Oct 20, 2025
@brian-smith-tcril
Copy link
Contributor

@arbrandes do you remember which FWG meeting we discussed this in? I think I need to look through our discussion to remember how the "render conditionally based on role" part is supposed to work (IIRC we talked about apps having roles associated?)

@diana-villalvazo-wgu
Copy link
Author

@arbrandes do you remember which FWG meeting we discussed this in? I think I need to look through our discussion to remember how the "render conditionally based on role" part is supposed to work (IIRC we talked about apps having roles associated?)

we discussed it on this one https://openedx.atlassian.net/wiki/spaces/COMM/pages/5255593985/2025-10-09+Frontend+Working+Group+Meeting+Notes+Shai-Hulud+Program+Dashboard+etc

For now i didn't introduce anything related to roles and just abstract how is working now (retrieving the enabled tabs from the course-metadata endpoint)

@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Nov 6, 2025
@mphilbrick211 mphilbrick211 moved this from In Eng Review to Ready for Review in Contributions Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants