-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add streamedListObjects for unlimited object retrieval #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0c2a0ab
6fe722d
b010a25
3036f36
0279076
71160b3
d149317
b2fa56f
9d593dd
d8ffd07
0d47948
2d523ed
5316902
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -342,6 +342,77 @@ export const createRequestFunction = function (axiosArgs: RequestArgs, axiosInst | |||||||||
| ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| return result; | ||||||||||
| }; | ||||||||||
| }; | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * creates an axios streaming request function that returns the raw response stream | ||||||||||
| * for incremental parsing (used by streamedListObjects) | ||||||||||
| */ | ||||||||||
| export const createStreamingRequestFunction = function (axiosArgs: RequestArgs, axiosInstance: AxiosInstance, configuration: Configuration, credentials: Credentials, methodAttributes: Record<string, string | number> = {}) { | ||||||||||
| configuration.isValid(); | ||||||||||
|
|
||||||||||
| const retryParams = axiosArgs.options?.retryParams ? axiosArgs.options?.retryParams : configuration.retryParams; | ||||||||||
| const maxRetry: number = retryParams ? retryParams.maxRetry : 0; | ||||||||||
| const minWaitInMs: number = retryParams ? retryParams.minWaitInMs : 0; | ||||||||||
|
Comment on lines
+357
to
+358
|
||||||||||
| const maxRetry: number = retryParams ? retryParams.maxRetry : 0; | |
| const minWaitInMs: number = retryParams ? retryParams.minWaitInMs : 0; | |
| const maxRetry: number = retryParams?.maxRetry ?? 0; | |
| const minWaitInMs: number = retryParams?.minWaitInMs ?? 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server version requirement mentioned in the PR description (OpenFGA server v1.2.0+) is missing from the CHANGELOG entry. Following the pattern used for similar features (see line 14 in CHANGELOG.md for conflict options), the version requirement should be documented here.
Consider updating to: