-
Notifications
You must be signed in to change notification settings - Fork 260
Fix bitrot issues due to updated Verilator and Python versions #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a solid cleanup, the build system is now easier to maintain and more flexible. Using ?= lets people override settings without editing the Makefile, quoting in find makes it safer, and splitting the flags makes things clearer. The only thing to check is whether any CI scripts still use the old VERI_FLAGS name. But I think if all the tests are passed we are good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It very clean makes regex intent clear and avoids issues with backslash escaping.
Uzair-90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching the regex patterns to raw strings makes them clearer and avoids any issues with escape sequences. The Makefile updates are a solid improvement variables can now be overridden more easily, the compile and run flags are separated for clarity, and quoting in the find commands makes things safer.
The only thing worth double-checking is whether any scripts or CI jobs still reference the old VERI_FLAGS name, since that’s now VERI_RUN_FLAGS. Other than that, this is a clean, safe, and maintainable refactor. But I think if all tests are passed we are good for now.
|
Hi @MikeOpenHWGroup I have closed issue #2630 as the PR was merged. Please go on with the changes and you can assign me the review. |
|
OK @Uzair-90, I have resolved the merge conflict. Please have a look (and thanks!). |
Hi @Uzair-90, while reviewing your PR (#2631), I noticed a few other (non-fatal) issues. Please have a look at these and let me know what you think.