Skip to content

Conversation

@cairo-caplan
Copy link

This PR introduces three features:

  • Parametrization of the SEC script, so the user can choose whether they want to execute it with the CV-X-IF enabled or disabled
    • So far, it stripped out extra signals from the proposed/revised version and tested only the base configuration, with the CV-X-IF functionality disabled.
  • Creation of a GitHub workflow action, triggered by PRs that change the /rtl/ directory, that execute SEC with the CV-X-IF enabled and with it disabled

Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the license @cairo-caplan.

I am approving this PR based on a visual review. I currently lack the ability to actually run this workflow locally, so I am not going to merge it (but you or @davideschiavone should feel free to do so).

@davideschiavone davideschiavone self-requested a review November 19, 2025 07:54
Copy link

@davideschiavone davideschiavone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @cairo-caplan , thanks a lot for the PR.

can you please add a few lines in the SEC README regarding the new options you added and how they are inteded to use?

Also, it would be nice if you can add in the documentation the SEC section about Yosys, how to install it (like the version number or so) and run it IMO

Thanks

@cairo-caplan
Copy link
Author

hi @cairo-caplan , thanks a lot for the PR.

can you please add a few lines in the SEC README regarding the new options you added and how they are inteded to use?

Also, it would be nice if you can add in the documentation the SEC section about Yosys, how to install it (like the version number or so) and run it IMO

Thanks

Thank you for reviewing it, @davideschiavone .

I updated the SEC Readme regarding the new optios and the current state of the SEC script. However, I did not specify version numbers for the tools (Yosys/Yosys EQY and Yosys-slang), as I have been using the latest version provided and packed on the YosysHQ's OSS CAD suite - and so is the case for the CI workflow script I created on .github/workflows/pr_sec.yml :

https://github.com/cairo-caplan/cve2/blob/f55eeb365f989a5949c95b77c584db69e21de8bb/.github/workflows/pr_sec.yml#L48-L49

I think that, for this SEC script, it is ok to leave it unversioned until we become aware of a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants