-
Notifications
You must be signed in to change notification settings - Fork 34
Parametrization of the SEC script regarding the use of CV-X-IF and GitHub action to run SEC on PRs with RTL changes #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…th the option to enable the CV-X-IF
SEC script support for parametrization of the CV-X-IF and GitHub Action
MikeOpenHWGroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the license @cairo-caplan.
I am approving this PR based on a visual review. I currently lack the ability to actually run this workflow locally, so I am not going to merge it (but you or @davideschiavone should feel free to do so).
davideschiavone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @cairo-caplan , thanks a lot for the PR.
can you please add a few lines in the SEC README regarding the new options you added and how they are inteded to use?
Also, it would be nice if you can add in the documentation the SEC section about Yosys, how to install it (like the version number or so) and run it IMO
Thanks
Thank you for reviewing it, @davideschiavone . I updated the SEC Readme regarding the new optios and the current state of the SEC script. However, I did not specify version numbers for the tools (Yosys/Yosys EQY and Yosys-slang), as I have been using the latest version provided and packed on the YosysHQ's OSS CAD suite - and so is the case for the CI workflow script I created on I think that, for this SEC script, it is ok to leave it unversioned until we become aware of a breaking change. |
This PR introduces three features:
/rtl/directory, that execute SEC with the CV-X-IF enabled and with it disabled