-
Notifications
You must be signed in to change notification settings - Fork 12
Create proposed_stable_requirements.md #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| * _MUST distribute discovery metadata (such as the authorization endpoint) via the metadata document as specified in [OpenID.Discovery];_ | ||
| * _MUST reject requests using the resource owner password credentials grant;_ | ||
| * _MUST support public clients as defined in [RFC6749];_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If for security reasons, an enterprise doesn't want to support public clients, then they can't claim IPSIE one compliance? Or does the IDP enable support for conformance testing and then turn off the support? Is that acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is where we landed when we last discussed it. We'll have to go check meeting notes to see.
If we think it's not stable, we can remove it from the proposed list of stable requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe require public clients to use DCR? Is that both supporting them and "not" supporting them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created issue #116 to cover this topic
|
|
||
| Access Tokens issued by OpenID Providers: | ||
|
|
||
| * _MUST only be used by the RP to retrieve identity claims at the OpenID Provider;_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is confusing. From an IPSIE perspective, the spec is only addressing the use of access tokens at the /userinfo endpoint to retrieve identity claims. I don't think IPSIE should be limiting how a returned access token may be used by the client. Maybe something like...
- MUST support use by the RP to retrieve identity claims at the OpenID Provider;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a PR on the current working draft or file an issue. This was pulled straight from the most recent update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #115 created
| * _MUST issue authorization codes with a maximum lifetime of 60 seconds;_ | ||
| * _MUST return an `iss` parameter in the authorization response according to [RFC9207];_ | ||
| * _MUST NOT transmit authorization responses over unencrypted network connections, and, to this end, MUST NOT allow redirect URIs that use the `http` scheme;_ | ||
| * _MUST reject an authorization code (Section 1.3.1 of [RFC6749]) if it has been previously used;_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this requirement though for geo-graphically distributed deployments, this can get complicated for the OPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a suggested fix, file a PR for discussion please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did have issues with this particularly in FAPI1. FAPI itself says no reuse, the position we ended up in the certification tests for final is that exchanging an authorization code 1 second after the first use must be rejected.
gffletch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the responses Dean. I've create two issues. Approving this PR.
As an artifact to inspire discussion, I took a set of requirements from the SL1 OIDC profile and highlighted what I believe to be stable requirements (e.g. not likely to change before we get to a final document). The goal is to enable OIDF to start to develop conformance tests as early as possible in the IPSIE lifecycle, while avoiding any tests that are likely to change before IPSIE OIDC SL1 is published.