8283544: HttpClient GET method adds Content-Length: 0 header

[GoeLin]

I backport this for parity with 17.0.18-oracle.

Clean backport. Original change is in 19.

The test does not build as https://bugs.openjdk.org/browse/JDK-8276559 (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.
is not in 17. It was only added in 18. Subtest headWithNoBody() is the problem.

I could replace the call to HEAD() by the implementation of that simple method.
This does not work though. The test uses the HttpRequestBuilderImpl. There
HEAD() is implemented as return method0("HEAD", null);
But method0 is private, and method() rejects null.

Using the implementation of the default method in HttpRequest does not work with HttpRequestBuilderImpl.
In this case the test returns a Http error 400.

Thus I just omit the test. See second commit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8283544 needs maintainer approval

Issue

• JDK-8283544: HttpClient GET method adds Content-Length: 0 header (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/413/head:pull/413
$ git checkout pull/413

Update a local copy of the PR:
$ git checkout pull/413
$ git pull https://git.openjdk.org/jdk17u.git pull/413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 413

View PR using the GUI difftool:
$ git pr show -t 413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/413.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283544: HttpClient GET method adds Content-Length: 0 header

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (cfb046bc)

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 3c17462.

[openjdk]

@GoeLin Pushed as commit 3c17462.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.