Skip to content

Conversation

@GautamBytes
Copy link
Contributor

This PR completes the work for issue #8 by building on the foundation from the first PR and adding support for the four remaining workloads.

Changes:

  • Extends the selector helper in mapbasedselectorforobject.go to correctly handle the new types.
  • Adds top subcommands for:
    • AdvancedStatefulSet (alias: asts)
    • AdvancedDaemonSet (alias: ads)
    • UnitedDeployment (alias: ud)
    • BroadcastJob (alias: bcj)

How to test:

# With metrics-server installed in the cluster:
./kubectl-kruise top advancedstatefulset <name> -n <namespace>
./kubectl-kruise top advanceddaemonset <name> -n <namespace>
./kubectl-kruise top uniteddeployment <name> -n <namespace>
./kubectl-kruise top broadcastjob <name> -n <namespace>

@kruise-bot kruise-bot requested review from furykerry and hantmac July 1, 2025 15:19
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GautamBytes
Copy link
Contributor Author

@furykerry I have raised this pr in support of this pr . Once that pr is merged , i will mark this ready for review after rebasing the branch!

@GautamBytes GautamBytes marked this pull request as ready for review August 15, 2025 14:38
@kruise-bot kruise-bot requested a review from FillZpp August 15, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants